Menu Pref -- Always Show Triggers non-functional (easy)

[mmadia]

build 20674 on real hardware

The triggers -- underlined letters in menus are always activated. The Menu Pref app defaults to the setting not being enabled.

[mmadia]

should have played more before submitting the bug....

The Font, Font Size, and Color Scheme settings also have no effect on Tracker's menus. I have tried applying settings, quitting and restarting tracker through Process Controller -> Quit an App -> Tracker to no avail.

The Settings seem local to the Menu Pref program itself.

However. the choice between CTRL / ALT as Shortcut Key works. ( switching it results in on-the-fly changes )

[mmadia]

possible regression of ​http://dev.haiku-os.org/ticket/521 ?

[jackburton]

Replying to mmadia:

should have played more before submitting the bug....

The Font, Font Size, and Color Scheme settings also have no effect on Tracker's menus. I have tried applying settings, quitting and restarting tracker through Process Controller -> Quit an App -> Tracker to no avail.

The Settings seem local to the Menu Pref program itself.

Are you sure you are using a current build ? Because the menu font size is the first thing I change every time I start haiku, and I can assure you it works correctly since many revisions. To see the change in Tracker & Deskbar you need to restart them, though.

[mmadia]

Replying to jackburton:

Replying to mmadia:

should have played more before submitting the bug....

The Font, Font Size, and Color Scheme settings also have no effect on Tracker's menus. I have tried applying settings, quitting and restarting tracker through Process Controller -> Quit an App -> Tracker to no avail.

The Settings seem local to the Menu Pref program itself.

Are you sure you are using a current build ? Because the menu font size is the first thing I change every time I start haiku, and I can assure you it works correctly since many revisions. To see the change in Tracker & Deskbar you need to restart them, though.

yeah, the build number is correct. somehow i was mistaken in my first reply -- it works as expected. (oops)

but the initial report of the "Always Show Triggers" not working as expected remains.

[anxiety]

I've been looking into this... and I think I have fixed the basic issue. The menu's local cached version wasn't getting set to the system setting when it was initialized.

I noticed another problem though... changing the setting in the Menu pref app does not immediately change all menus in the system but the change will show on any new menus that are created. This is the same for all menu settings, not just "Always Show Triggers." It would seem that there should be some better way of caching the value (which is needed for when custom data is sent) or some sort of global broadcast message alerting each menu that it needs to reevaluate the system settings if it isn't using custom settings. I don't know enough about the system to have any opinion on that.

[anxiety]

Diff file

[anxiety]

Just loaded up a copy of R5... it doesn't seem to change all menus instantly either, so I guess its a non-issue.

[leavengood]

Patch committed in hrev22011. I consider this bug solved. Thanks Justin.