Terminal mouse button functions confusing; should be swapped

[grackle]

Right clicking in the terminal pastes text, while middle clicking opens a contextual menu of questionable usefulness.

The attached patch swaps the contextual menu and paste buttons, so that the menu is invoked with the RMB, and pasting is achieved using the MMB. The contextual menu is also modified, replacing encoding choices in favor of text selection and copy functions.

[wkornewald]

Thanks for the patch. I hope Axel will commit it. :)

[grackle]

updated diff; doesn't change anything, just a little cleaner

[marcusoverhagen]

I don't like that patch.

Right clicking always pasts text in BeOS, and I think it should be that way in Haiku, too

[wkornewald]

But it's more consistent with the behavior of all other apps. I don't see a reason why we should repeat BeOS' inconsistencies.

[axeld]

Thanks for the patch, grackle. However, I opted to not include it, and instead remove the popup menu completely; in either way I consider it pretty much useless. I also solved your "confusion" as both mouse buttons now do the very same thing - pasting into the Terminal.

Also, when you provide a patch, please make sure you don't add unrelated content; in your (cleaned) patch, you still change TermWindow.cpp for no good reason.

[axeld]

Forgot to add: fixed in hrev20772.

[wkornewald]

That's OK, too. :)

[grackle]

Replying to axeld:

Also, when you provide a patch, please make sure you don't add unrelated content; in your (cleaned) patch, you still change TermWindow.cpp for no good reason.

Hmm, I thought I needed that change for the copy/paste functions in the contextual menu. In any case, I'll keep an eye out for that kind of thing in the future.