Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#1159 closed bug (fixed)

Terminal mouse button functions confusing; should be swapped

Reported by: grackle Owned by: axeld
Priority: normal Milestone: R1
Component: Applications/Terminal Version: R1/pre-alpha1
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

Right clicking in the terminal pastes text, while middle clicking opens a contextual menu of questionable usefulness.

The attached patch swaps the contextual menu and paste buttons, so that the menu is invoked with the RMB, and pasting is achieved using the MMB. The contextual menu is also modified, replacing encoding choices in favor of text selection and copy functions.

Attachments (1)

terminal_update.diff (2.0 KB ) - added by grackle 12 years ago.
updated diff; doesn't change anything, just a little cleaner

Download all attachments as: .zip

Change History (8)

comment:1 by wkornewald, 12 years ago

Type: enhancementbug

Thanks for the patch. I hope Axel will commit it. :)

by grackle, 12 years ago

Attachment: terminal_update.diff added

updated diff; doesn't change anything, just a little cleaner

comment:2 by marcusoverhagen, 12 years ago

I don't like that patch.

Right clicking always pasts text in BeOS, and I think it should be that way in Haiku, too

comment:3 by wkornewald, 12 years ago

But it's more consistent with the behavior of all other apps. I don't see a reason why we should repeat BeOS' inconsistencies.

comment:4 by axeld, 12 years ago

Resolution: fixed
Status: newclosed

Thanks for the patch, grackle. However, I opted to not include it, and instead remove the popup menu completely; in either way I consider it pretty much useless. I also solved your "confusion" as both mouse buttons now do the very same thing - pasting into the Terminal.

Also, when you provide a patch, please make sure you don't add unrelated content; in your (cleaned) patch, you still change TermWindow.cpp for no good reason.

comment:5 by axeld, 12 years ago

Forgot to add: fixed in hrev20772.

comment:6 by wkornewald, 12 years ago

That's OK, too. :)

in reply to:  4 comment:7 by grackle, 12 years ago

Replying to axeld:

Also, when you provide a patch, please make sure you don't add unrelated content; in your (cleaned) patch, you still change TermWindow.cpp for no good reason.

Hmm, I thought I needed that change for the copy/paste functions in the contextual menu. In any case, I'll keep an eye out for that kind of thing in the future.

Note: See TracTickets for help on using tickets.