Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#11711 closed enhancement (fixed)

[PATCH] Use vector icons in the Tracker status window.

Reported by: waddlesplash Owned by: waddlesplash
Priority: low Milestone: Unscheduled
Component: Applications/Tracker Version: R1/Development
Keywords: gci2014 Cc:
Blocked By: Blocking: #4272
Has a Patch: yes Platform: All

Description

Patch attached, for this GCI task.

I left the old bitmap icons in because the icon system is set up to fall back to them on systems that don't have vector icons (BeOS/Zeta).

Attachments (1)

0001-Tracker-StatusWindow-use-vector-icons.patch (9.3 KB) - added by waddlesplash 4 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 4 years ago by waddlesplash

Has a Patch: set

comment:2 Changed 4 years ago by axeld

Is the alpha channel correctly drawn? IIRC you have to switch to B_OP_ALPHA in order to do that. Otherwise, the patch looks good (I haven't actually tested, it though, but I hope you have :-)).

Also, we usually remove BeOS/Dano compatibility code when working on a file; there is really no reason to keep this around nowadays.

comment:3 Changed 4 years ago by waddlesplash

OK, well there are a lot of icons that are still bitmaps, and I haven't taken the time to double-check that every single one is no longer used. After this and tracker_layout is merged, I intend to do a brute-force cleanup of the tracker sources to remove all the unuesd/outdated code and resources.

Also, yes, I tested this and it draws correctly -- the previous icons had a transparent background too, so I don't know why this would be any different.

Changed 4 years ago by waddlesplash

comment:4 Changed 4 years ago by waddlesplash

Owner: changed from axeld to waddlesplash
Status: newassigned

comment:5 Changed 4 years ago by waddlesplash

Resolution: fixed
Status: assignedclosed

Fixed in hrev48794.

comment:6 Changed 4 years ago by diver

Blocking: 4272 added
Note: See TracTickets for help on using tickets.