#11711 closed enhancement (fixed)
[PATCH] Use vector icons in the Tracker status window.
Reported by: | waddlesplash | Owned by: | waddlesplash |
---|---|---|---|
Priority: | low | Milestone: | Unscheduled |
Component: | Applications/Tracker | Version: | R1/Development |
Keywords: | gci2014 | Cc: | |
Blocked By: | Blocking: | #4272 | |
Platform: | All |
Description
Patch attached, for this GCI task.
I left the old bitmap icons in because the icon system is set up to fall back to them on systems that don't have vector icons (BeOS/Zeta).
Attachments (1)
Change History (7)
comment:1 by , 10 years ago
patch: | 0 → 1 |
---|
comment:2 by , 10 years ago
comment:3 by , 10 years ago
OK, well there are a lot of icons that are still bitmaps, and I haven't taken the time to double-check that every single one is no longer used. After this and tracker_layout is merged, I intend to do a brute-force cleanup of the tracker sources to remove all the unuesd/outdated code and resources.
Also, yes, I tested this and it draws correctly -- the previous icons had a transparent background too, so I don't know why this would be any different.
by , 10 years ago
Attachment: | 0001-Tracker-StatusWindow-use-vector-icons.patch added |
---|
comment:4 by , 10 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:6 by , 10 years ago
Blocking: | 4272 added |
---|
Is the alpha channel correctly drawn? IIRC you have to switch to B_OP_ALPHA in order to do that. Otherwise, the patch looks good (I haven't actually tested, it though, but I hope you have :-)).
Also, we usually remove BeOS/Dano compatibility code when working on a file; there is really no reason to keep this around nowadays.