Opened 10 years ago
Closed 10 years ago
#11747 closed bug (no change required)
CID 30948: Missing break in switch
| Reported by: | sli908 | Owned by: | nobody |
|---|---|---|---|
| Priority: | normal | Milestone: | R1 |
| Component: | - General | Version: | R1/Development |
| Keywords: | gci2014 | Cc: | |
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
Added a break statement to prevent falling into the next case.
Attachments (1)
Change History (4)
by , 10 years ago
| Attachment: | 0001-CID-30948-Missing-break-in-switch-Added.patch added |
|---|
comment:1 by , 10 years ago
| patch: | 0 → 1 |
|---|
comment:2 by , 10 years ago
Are you sure this is needed? It looks like the fallthrough might be intentional because the handling of ? and * is similar. Moreover, the indenting of your "break" is wrong, if it is needed, it should be outside the "if" body.
comment:3 by , 10 years ago
| Resolution: | → no change required |
|---|---|
| Status: | new → closed |
Furthermore, even if it was valid, it's in 3rd party code that we probably don't want/need to patch at this point (gdb and dependencies will probably be removed from our tree entirely someday).
Closing as no change.
Note:
See TracTickets
for help on using tickets.
Patch that adds the missing break statement