Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#11755 closed enhancement (duplicate)

[PATCH] Implement getpriority and setpriority

Reported by: Timothy_Gu Owned by: nobody
Priority: normal Milestone: R1
Component: System/POSIX Version: R1/Development
Keywords: gci2014 Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

Done as a part of GCI 2014.

Fixes #2817.

Attachments (2)

0001-libroot-add-gs-etpriority-implementation.2.patch (8.6 KB) - added by Timothy_Gu 4 years ago.
0001-libroot-add-gs-etpriority-implementation.patch (8.6 KB) - added by Timothy_Gu 4 years ago.
Patch

Download all attachments as: .zip

Change History (8)

comment:1 Changed 4 years ago by Timothy_Gu

Has a Patch: set

Changed 4 years ago by Timothy_Gu

Patch

comment:2 Changed 4 years ago by Timothy_Gu

Another question is if we should make the priority notation conversion functions public.

comment:3 Changed 4 years ago by pulkomandy

Blocked By: 2817 added
Resolution: duplicate
Status: newclosed

You should attach your patches to the existing ticket #2817 directly instead of opening a new one.

comment:4 Changed 4 years ago by pulkomandy

Blocked By: 2817 removed

(In #2817) There is a limitation with the approach you implemented in these patches: the priority only applies to existing threads. As discussed in this ticket, a better solution would be to have a process-global "nice" value and also use it when creating new threads to adjust their priorities.

comment:5 in reply to:  3 Changed 4 years ago by Timothy_Gu

Replying to pulkomandy:

You should attach your patches to the existing ticket #2817 directly instead of opening a new one.

On the GCI task it is said to:

Open a new trac ticket and attach your patch to it.

comment:6 Changed 4 years ago by Timothy_Gu

See more discussion on #2817.

Note: See TracTickets for help on using tickets.