Implement BMediaRoster::SyncToNode

[Barrett]

SyncToNode allow to set a performance time and get the function returns when the specified node reach this time. While i don't know one app that use this part of the BeOS API it should be implemented as it's a useful functionality and may become handy in future. It's anyway a missing part of BeOS API.

[jackburton]

Some comments on the patch:

port_id wait_port = create_port(1, "SyncToNode wait port");

if (wait_port == B_BAD_VALUE

wait_port == B_NO_MORE_PORTS)

return wait_port;

Is it correct to only check wait_port against these error codes ? Shouldn't this line read

if (wait_port < 0)

Same thing later, in

read_port_etc(wait_port, &code, &reply, sizeof(reply),

You only check for B_TIMEOUT, although you check the "code" varibale later, but maybe you should also check if read_port succeeded ?

[Barrett]

I was a bit uncertain on how to handle those situations, i've fixed it in the new patch.

[Barrett]

Could someone look at this one?

[Barrett]

Fix NodeTest and add SyncToNode test.

[Barrett]

I'm trying to make my branch more slim so that i don't have too many beef on the roaster. I don't know what to do with the notifyPoint argument except use it for some logging.

[korli]

The if statement in TimerExpired() is multilines, thus requires braces. The call to read_port_etc() has 0 as second argument, it should be NULL.

[Barrett]

An attempt to be more consistent.

[Barrett]

Is there something missing to get the code applied?

On a side note the MixALot sample code from Be is using this function.

[Barrett]

Updated patches of SyncToNode have been published into this branch:

​https://github.com/Barrett17/haiku/commits/mediaroster

[Barrett]

Fixed in hrev49387.