Opened 10 years ago

Closed 9 years ago

#11922 closed bug (fixed)

[PATCHSET] Add missing part of BMediaRoster and other improvements in media_kit

Reported by: Barrett Owned by: Barrett
Priority: normal Milestone: R1
Component: Kits/Media Kit Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Platform: All

Description

This patch improve various aspects of the media_kit and media_server, this is a little summary :

  • Add BMediaRoster::IsRunning, SyncToNode (#11856) and GetFormatsFor
  • General improvements in style and error checking
  • Fix #5621
  • Add a new service for detecting when media services are up/down and use it to remove code duplication, make BMediaRoster survive to media_server reboot by reestabilishing the connection, make media_server to watch when the media_addon_server quit and call the cleanup function, which was leaved here uncomplete and unused until i get on it.

Attachments (14)

0003-Add-more-checking-for-BFileInterface-related-methods.patch​ (1.5 KB ) - added by Barrett 10 years ago.
0001-Add-SyncToNode-test-to-NodeTest-and-update-it-to-act.patch​ (2.8 KB ) - added by Barrett 10 years ago.
This new patch just fix a line going over 80 characters.
0002-Implement-BMediaRoster-SyncToNode.patch​ (5.8 KB ) - added by Barrett 10 years ago.
Fix things suggested by korli
0004-Implement-BMediaRoster-GetFileFormatsFor.2.patch​ (3.7 KB ) - added by Barrett 10 years ago.
0004-Implement-BMediaRoster-GetFileFormatsFor.patch​ (3.6 KB ) - added by Barrett 10 years ago.
0005-Add-BMediaRoster-IsRunning-which-check-if-media-serv.patch​ (1.7 KB ) - added by Barrett 10 years ago.
0006-Make-launch_media_server-to-handle-the-case-when-the.patch​ (1.4 KB ) - added by Barrett 10 years ago.
0007-BMediaRosterEx-cleanup-and-fix-style-in-the-header.patch​ (4.8 KB ) - added by Barrett 10 years ago.
0008-NodeManager-Add-missing-notifications-for-node-delet.patch​ (2.7 KB ) - added by Barrett 10 years ago.
0009-Add-myself-to-contributors-list.patch​ (708 bytes ) - added by Barrett 10 years ago.
0010-Add-support-to-BMediaRoster-for-B_MEDIA_SERVER_START.patch​ (12.3 KB ) - added by Barrett 10 years ago.
0011-VolumeControl-and-Media-preferences-add-support-for-.patch​ (6.4 KB ) - added by Barrett 10 years ago.
0012-media_server-watch-for-media-services-status-and-cal.patch​ (1.9 KB ) - added by Barrett 10 years ago.
0013-MediaPlayer-add-support-for-new-media-services-notif.patch​ (6.7 KB ) - added by Barrett 10 years ago.

Download all attachments as: .zip

Change History (21)

comment:1 by Barrett, 10 years ago

patch: 0 → 1

by Barrett, 10 years ago

Attachment: 0003-Add-more-checking-for-BFileInterface-related-methods.patch​ added

comment:2 by korli, 10 years ago

About 0002:

  • port < B_OK is usually used to check for an error on create_port() call.
  • status and reply.status should be checked for B_OK equality.
  • "else status = B_OK;" can then be left out.
  • shouldn't BMediaNode::TimerExpired() do something with the parameters notifyPoint and error?
  • wait_port isn't a coding style valid c++ name. waitPort would be better.

comment:3 by Barrett, 10 years ago

I'm preparing an update to the whole patchset. About BMediaNode::TimerExpired() the error argument is set to B_OK as default and i don't know what i could do with notifyPoint, do you have any suggestion? I suppose they were here to support non-BMediaEventLooper implementations.

by Barrett, 10 years ago

Attachment: 0001-Add-SyncToNode-test-to-NodeTest-and-update-it-to-act.patch​ added

This new patch just fix a line going over 80 characters.

by Barrett, 10 years ago

Attachment: 0002-Implement-BMediaRoster-SyncToNode.patch​ added

Fix things suggested by korli

by Barrett, 10 years ago

Attachment: 0004-Implement-BMediaRoster-GetFileFormatsFor.2.patch​ added

comment:4 by Barrett, 10 years ago

Sorry for double upload of 0004 it's not really comfortable to update patches here. I've fixed what you suggested and made other updates on the other patches for minor details such as comments and code style.

by Barrett, 10 years ago

Attachment: 0004-Implement-BMediaRoster-GetFileFormatsFor.patch​ added

by Barrett, 10 years ago

Attachment: 0005-Add-BMediaRoster-IsRunning-which-check-if-media-serv.patch​ added

by Barrett, 10 years ago

Attachment: 0006-Make-launch_media_server-to-handle-the-case-when-the.patch​ added

by Barrett, 10 years ago

Attachment: 0007-BMediaRosterEx-cleanup-and-fix-style-in-the-header.patch​ added

by Barrett, 10 years ago

Attachment: 0008-NodeManager-Add-missing-notifications-for-node-delet.patch​ added

by Barrett, 10 years ago

Attachment: 0009-Add-myself-to-contributors-list.patch​ added

by Barrett, 10 years ago

Attachment: 0010-Add-support-to-BMediaRoster-for-B_MEDIA_SERVER_START.patch​ added

by Barrett, 10 years ago

Attachment: 0011-VolumeControl-and-Media-preferences-add-support-for-.patch​ added

by Barrett, 10 years ago

Attachment: 0012-media_server-watch-for-media-services-status-and-cal.patch​ added

by Barrett, 10 years ago

Attachment: 0013-MediaPlayer-add-support-for-new-media-services-notif.patch​ added

comment:6 by Barrett, 9 years ago

Owner: changed from axeld to Barrett
Status: new → assigned

comment:7 by Barrett, 9 years ago

Resolution: → fixed
Status: assigned → closed

All remaining code applied in hrev49445.

Note: See TracTickets for help on using tickets.