Opened 4 years ago

Last modified 4 years ago

#11949 new bug

Termianl fullscreen are broken

Reported by: stargater Owned by: jackburton
Priority: normal Milestone: R1
Component: Applications/Terminal Version: R1/Development
Keywords: Fullscreen Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

When i used Terminal in Fullscreen then it is broken, i have on the right side free spaces, so it fill not my desktop.

I show the code and i see some ugly code e.g ResizeTo before MoveTo and Frame() handling to save the last window size and position.

fSavedFrame = Frame(); ? why. You mean the Window Frame!

The theory are: Set some Window flags/looks e.g: B_NOT_RESIZABLE, etc. BScreen screen(this); ResizeTo(screen.Frame().Width(), screen.Frame().Height();

terminal/TermWindow.cpp 884 found the code.

My screen are 1920x1080 pixels.

Thanks

Change History (5)

comment:1 Changed 4 years ago by Janus

The code seems fine to me. The fSavedFrame is used when the terminal exits fullscreen to set the old window size.

Could you try this:

1) open a terminal in the first workspace (only one window) 2) go to fullscreen mode (alt-return) 3) quit the terminal in fullscreen (alt-Q) 4) reopen the terminal and type this command:

message /boot/home/config/settings/Terminal/Windows

5) post the output.

Do you have this problem with other resolutions?

Thanks.

comment:2 Changed 4 years ago by pulkomandy

I think there is a limitation to the maximal width of terminal windows. IIRC it is somewhere around 256 characters, as anything above that has problems with using curses applications (some infos such as window size, mouse coordinates are sent as 8 bit values). It is possible to make the window bigger but such apps could run into problems because of this, so we must not allow mouse clicks after the 256th column, make sure the window size is properly reported (or clipped), etc.

comment:3 Changed 4 years ago by pulkomandy

Milestone: R1/beta1R1

comment:4 Changed 4 years ago by Janus

I can go fullscreen without problem in 1920x1080. I have set the font to a bigger size than the default, this explain the different behaviour.

Last edited 4 years ago by Janus (previous) (diff)

comment:5 Changed 4 years ago by stargater

Can we calculate the min font size by screen size? So can we set a new min. fon size when we used fullscreen.

Note: See TracTickets for help on using tickets.