Opened 4 years ago

Closed 21 months ago

#11979 closed bug (fixed)

Missing shortcuts in file panels

Reported by: humdinger Owned by: waddlesplash
Priority: normal Milestone: R1
Component: Kits/libtracker.so Version: R1/Development
Keywords: Cc: jessicah
Blocked By: Blocking: #12096
Has a Patch: yes Platform: All

Description

This is hrev49043.

There are some keyboard shortcuts missing from the open/save file panels.

  • ALT+Up doesn't send you up one level to the parent folder.
  • ALT+W should close the panel.

I also happened upon some panels where ALT+H and ALT+D don't send you to Home and Desktop. It works on some apps and doesn't on others. StyledEdit is such a case where it doesn't work. In Pe on the other, it works...

Attachments (2)

Change History (27)

comment:1 Changed 4 years ago by waddlesplash

Owner: changed from nobody to waddlesplash
Status: newassigned

comment:2 Changed 4 years ago by diver

Blocking: 12096 added

comment:3 Changed 4 years ago by diver

Milestone: UnscheduledR1/beta1

comment:4 Changed 4 years ago by jessicah

Cc: jessicah added

comment:5 Changed 4 years ago by pulkomandy

Milestone: R1/beta1R1

comment:6 Changed 3 years ago by diver

Maybe we could create a GCI task to do a git bisect to find out when shortcuts stopped working?

comment:7 Changed 3 years ago by waddlesplash

It probably was the tracker_layout commit, but as I think I said before, I've no clue how or why :(

If someone who knows more about Tracker and BView internals could look at this, that'd be best...

comment:8 Changed 2 years ago by diver

It looks like jessicah tried to fix it in 89486c92764891b1142243547d8e97fdc866c4f1 but then reverted it in hrev49212.

The bug is pretty annoying, could someone please take a look at it again?

comment:9 Changed 2 years ago by owenca

Both Alt+H and Alt+D keys work in Pe, StyleEdit, Expander, and Filer, so I only have to make Alt+Up and Alt+W work. See the attached patch below.

comment:10 Changed 2 years ago by owenca

Has a Patch: set

comment:11 Changed 2 years ago by owenca

Please disregard or remove the above patch. I will update the patch for #13151, and it will make Alt-Up work, too.

comment:12 Changed 2 years ago by pulkomandy

Has a Patch: unset

comment:13 Changed 2 years ago by owenca

I have a new patch, which fixes this ticket (and this ticket only).

Last edited 2 years ago by owenca (previous) (diff)

comment:14 Changed 2 years ago by owenca

Has a Patch: set

comment:15 Changed 2 years ago by diver

Does Alt+Left/Alt+Right work as well (after navigation to some directory)?

comment:16 in reply to:  15 Changed 2 years ago by owenca

I tested the patch with Tracker, Expander, and StyleEdit and saw no change in the behavior of Alt+Left/Right keys.

Last edited 2 years ago by owenca (previous) (diff)

comment:17 Changed 2 years ago by diver

I meant in filepanel itself.

comment:18 Changed 2 years ago by owenca

Yes, I tested it in the file panels of Expander and StyleEdit. I didn't see any difference. Neither Alt-Left nor Alt-Right did anything before and after the patch was applied. What are they supposed to do?

comment:19 Changed 2 years ago by diver

Just like in Tracker they're supposed to navigate to previous/next folder.

comment:20 Changed 2 years ago by owenca

That's why I said I compared the behavior of Alt-Left/Alt-Right across Tracker, Expander, and StyleEdit. They didn't have any effect with or without the patch. Left/Right works though.

comment:21 Changed 2 years ago by owenca

After you showed me how to set Tracker browser to single window, I can see what Alt-Left and Alt-Right keys do. :)

comment:22 Changed 2 years ago by humdinger

I have checked out the file panel behaviour with hrev51347 - with and without Owen's patches of #11979 and #13151.

Without patches:

App Panel Alt+H |Alt+D Alt+Up Alt+W Esc-close Esc-reset-filtering
PeOpenokok--okok
Saveokok--okok
StyledEditOpenokok--okok
Saveokok--okok
ShowImageOpen**--okok
Saveokok--okok
MediaPlayerOpenokok--okok
(playlist)Saveokok--okok
ExpanderOpen**--* ** *
FilerOpen**---* *

With #11979 and #13151:

App Panel Alt+H |Alt+D Alt+Up Alt+W Esc-close Esc-reset-filtering
PeOpenokokokokok* * *
Saveokokokokok* * *
StyledEditOpen**okokok* * *
Saveokokokokok* * *
ShowImageOpen**okokok* * *
Saveokokokokok* * *
MediaPlayerOpenokokokokok* * *
(playlist)Saveokokokokok* * *
ExpanderOpen**okokok* * *
FilerOpen**okokok* * *

* works after clicking into the file list or moving the selection with the cursor keys (even though file list had the blue focus border already)

* * Esc hides all files of the list

* * * Closes the panel instead of resetting the type-ahead-filtering

So, with the patches there's quite an improvement. I'd appreciate if someone more familiar with the Tracker code could look at the code changes and apply the patch.

The focus issues marked with * are a bit puzzling...
What should be improved is the ESC behaviour when the type-ahead filter is active. Then, the ESC should only reset/deactivate the filter. Currently that closes the panel right away (* * *).
See also #13151.

comment:23 Changed 2 years ago by pulkomandy

So we should fix at least handling of the ESC key before merging the patches. The issue with * being already present in some cases, we can investigate it after merging these patches.

comment:24 Changed 23 months ago by owenca

The patch attached to this ticket only fixes Alt+Up and Alt+W and should not change the behavior of Esc. Maybe we can merge this patch first?

comment:25 Changed 21 months ago by waddlesplash

Resolution: fixed
Status: assignedclosed

Applied (this ticket's patch only) in hrev51542. Thanks!

Note: See TracTickets for help on using tickets.