Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#12045 closed enhancement (fixed)

Small GUI unification of translators

Reported by: humdinger Owned by: Janus
Priority: normal Milestone: Unscheduled
Component: Preferences/DataTranslations Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

This is hrev49124.

The attached patch replaces "v" with "Version" as it's what all the other Translators do. Also some sentence casing. It all compiles and should work, but when I tested by putting the translators under non-packaged/ and rebooting with blacklisting the system JPEG translator, Tracker and all kinds of stuff crashed.
While I do think I converted the sprintf correctly to snprintf, I'd rather have someone else have a look and apply the patch. Thanks.

Attachments (1)

0001-Unify-version-output-v-vs-Version-sentence-casing.patch (5.0 KB ) - added by humdinger 4 years ago.
patch

Download all attachments as: .zip

Change History (6)

comment:1 by humdinger, 4 years ago

Has a Patch: set

comment:2 by axeld, 4 years ago

Patch looks good, please apply.

comment:3 by humdinger, 4 years ago

Resolution: fixed
Status: newclosed

Thanks for looking over it. Applied with hrev49142.

comment:4 by Janus, 4 years ago

humdinger, I was pushing your patch and my updates were rejected because of your commit...

You arrived always first!

Last edited 4 years ago by Janus (previous) (diff)

comment:5 by humdinger, 4 years ago

Sorry about that... /me runs victory lap. :)

Note: See TracTickets for help on using tickets.