usb_modeswitch.cpp missing several devices

[haiqu]

The following devices need to be added to src/add-ons/kernel/drivers/common/usb_modeswitch.cpp

Huawei E5377 USB modem/router Huawei HWD12 LTE USB modem stick

The required code follows:

{ /* MSG_HUAWEI_4 */
0x55, 0x53, 0x42, 0x43, 0x12, 0x34, 0x56, 0x78,
0x00, 0x00, 0x00, 0x00, 0x80, 0x01, 0x0a, 0x11,
0x06, 0x20, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01,
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
},

...

	{{ 0, 0, 0, HUAWEI_VENDOR, 0x1f02}, MSG_HUAWEI_3}, // E5377
	{{ 0, 0, 0, HUAWEI_VENDOR, 0x1f03}, MSG_HUAWEI_4}, // HWD12 LTE

I also note that this file object isn't being created, but I'm fairly unfamiliar with Jam so can't debug it at this stage. Consequently this functionality is missing from the build.

[haiqu]

Note: The C style comment (double-slash) was interpreted above as italics. The terms E5377 and HWD12 LTE were actually comments, not to be included as code.

[haiqu]

Argh. The above code contains an error. Should be:

{ /* MSG_HUAWEI_4 */

0x55, 0x53, 0x42, 0x43, 0x12, 0x34, 0x56, 0x78, 0x00, 0x00, 0x00, 0x00, 0x80, 0x01, 0x0a, 0x11, 0x06, 0x20, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00

},

[humdinger]

I edited the ticket description. You can use Preformatted Text for code snippets.

[haiqu]

Thanks humdinger. I've finally figured out how to use 'git diff' so am attaching a patch for this one. Cheers!

[haiqu]

OK, just checked several more websites and it appears the string supplied for the HWD12 LTE was incorrect. New patch attached.

[haiqu]

Add Huawei devices

[humdinger]

Replying to haiqu:

Thanks humdinger. I've finally figured out how to use 'git diff' so am attaching a patch for this one. Cheers!

You're on the right way. :)
To be perfect, please have a look at this wiki page on how to submit a formatted patch. That will include your name and the commit message and makes everything easier and repoducible. Thanks!

[haiqu]

Since I don't have commit access, this is the only way I can send changes. I've set git.name and git.email locally and patches still don't contain that information.

Here's the patch to enable the modeswitch for jam. Untested, the current build fails just after target 5300.

[haiqu]

Patch to enable usb_modeswitch code in build

[humdinger]

Replying to haiqu:

Since I don't have commit access, this is the only way I can send changes. I've set git.name and git.email locally and patches still don't contain that information.

You have to create a patch with "git format-patch" as described in the wiki I linked above.

[haiqu]

Yeah, read that page. Couldn't make any sense of it at all.

CVS and SVN may not have been as good, but at least I could use them.

[haiqu]

OK, I think I've got this. Added, committed and patch generated ...

[haiqu]

Tested patch today and it appears to be entirely successful:

• E5377 device no longer appears as a USB stick on the desktop
• turning off device no longer causes OS to drop into KDL
• device appears in /dev/bus/usb tree correctly

Can't really test any further until we get the TCP/IP glue to USB devices.

[korli]

Thanks for the patch. Did you have a look at latest usb-modeswitch-data? It seems they switched for a lot of devices to a simple message (Huawei new mode):

{ 
0x55, 0x53, 0x42, 0x43, 0x12, 0x34, 0x56, 0x78,
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x11,
0x06, 0x20, 0x00, 0x00, 0x01, 0x01, 0x00, 0x01,
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
},

It would be nice if you could check this and add similar Huawei devices IDs: 0x1f11, 0x1f15, 0x1f16, 0x1f17, 0x1f18, 0x1f19, 0x1f1b, 0x1f1c, 0x1f1d, 0x1f1e.

[haiqu]

Yes, that would make for a better patch, I agree. I actually got the data from a site specializing in the Raspberry Pi, which uses the same code interactively from the terminal. I did download part of the BSD package yesterday (the data part only, since I was interested in other devices) and noticed that they had new information direct from Huawei, but as yet haven't investigated this further. I'll get onto it and submit a new patch.

I also note that there is an existing driver called kernel/drivers/network/usb_ecm which *should* enable networking on this device once switched, but doesn't seem to do so. I'm thinking that maybe the device isn't being rescanned and added to the device tree after the modeswitch occurs but haven't yet looked further into that aspect.

[haiqu]

korli: OK, I've redone this patch. Now all Huawei devices from the latest docs are included, and the switch method used is the one recommended by the manufacturer.

Previous patches can be ignored, I did a reset of the local git repository before generating this one.

[korli]

Applied in hrev49165. Thanks!