Opened 4 years ago

Closed 4 years ago

#12057 closed bug (fixed)

Webpositive crash after update

Reported by: vidrep Owned by: korli
Priority: normal Milestone: Unscheduled
Component: Applications/WebPositive Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All


Update from hrev49135 x86_64 to hrev49155 x86_64. Webpositve now crashes every time. Debug report attached.

Attachments (2) (22.5 KB) - added by vidrep 4 years ago.
icu-renaming.patch (10.9 KB) - added by korli 4 years ago.
use ICU renamed namespace

Download all attachments as: .zip

Change History (12)

comment:1 Changed 4 years ago by pulkomandy

Owner: changed from pulkomandy to korli
Status: newassigned

comment:2 Changed 4 years ago by korli

It seems that despite being linked against icu55, libbe uses symbols from icu54 when the main executable links against icu54. Is it something expected? Anyway the Haikuports recipe includes the build option "--disable-renaming", the idea would be to remove the option, let libbe uses versioned symbols from icu55, the main executable will continue to use the symbols of icu54. Is there a problem with this approach? Has it eventually already been tried and rejected?

comment:3 Changed 4 years ago by pulkomandy

The "renaming" mode uses namespaces in a way that confuses gcc2, so it should stay disabled at least there.

For gcc4 I think it should work, but I'm not sure it's possible to write sourcecode that builds in both modes (I didn't try this since the early work on Locale Kit in 2009, so I'm not sure).

comment:4 Changed 4 years ago by korli

Ok, I enabled renaming locally and tested OK on x86_64. I had to patch the locale headers and classes, which hardcodes the icu namespace. Please have a look at the diff.

Changed 4 years ago by korli

Attachment: icu-renaming.patch added

use ICU renamed namespace

comment:5 Changed 4 years ago by korli

Has a Patch: set

comment:6 Changed 4 years ago by pulkomandy

It looks fine, as long as it builds with gcc2 there should be no problem.

comment:7 Changed 4 years ago by korli

I tried building icu on gcc2 with the renaming mode, then Haiku. It looks OK, gcc2 doesn't seem confused.

I'll go ahead with with x86_64 for now. Doing so on gcc2 would require a few package rebuilds.

comment:8 Changed 4 years ago by korli

Applied in hrev49161.

comment:9 Changed 4 years ago by vidrep

x86_64 working after update to hrev49161. Thanks.

comment:10 Changed 4 years ago by korli

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.