Webpositive crash after update

[vidrep]

Update from hrev49135 x86_64 to hrev49155 x86_64. Webpositve now crashes every time. Debug report attached.

[korli]

It seems that despite being linked against icu55, libbe uses symbols from icu54 when the main executable links against icu54. Is it something expected? Anyway the Haikuports recipe includes the build option "--disable-renaming", the idea would be to remove the option, let libbe uses versioned symbols from icu55, the main executable will continue to use the symbols of icu54. Is there a problem with this approach? Has it eventually already been tried and rejected?

[pulkomandy]

The "renaming" mode uses namespaces in a way that confuses gcc2, so it should stay disabled at least there.

For gcc4 I think it should work, but I'm not sure it's possible to write sourcecode that builds in both modes (I didn't try this since the early work on Locale Kit in 2009, so I'm not sure).

[korli]

Ok, I enabled renaming locally and tested OK on x86_64. I had to patch the locale headers and classes, which hardcodes the icu namespace. Please have a look at the diff.

[korli]

use ICU renamed namespace

[pulkomandy]

It looks fine, as long as it builds with gcc2 there should be no problem.

[korli]

I tried building icu on gcc2 with the renaming mode, then Haiku. It looks OK, gcc2 doesn't seem confused.

I'll go ahead with with x86_64 for now. Doing so on gcc2 would require a few package rebuilds.

[korli]

Applied in hrev49161.

[vidrep]

x86_64 working after update to hrev49161. Thanks.