Opened 9 years ago
Closed 9 years ago
#12226 closed task (fixed)
hvif2png Building on MacOS-X
| Reported by: | apl-haiku | Owned by: | apl-haiku |
|---|---|---|---|
| Priority: | normal | Milestone: | Unscheduled |
| Component: | Build System | Version: | R1/Development |
| Keywords: | hvif2png | Cc: | |
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
The hvif2png tool was not building on MacOS-X. I am using mac-ports to get the libpng library in so have added path elements to the libs and includes for macports libpng and also had to make a small change to the linking args. I'm a bit new to jam etc... but hopefully these changes are in the right places.
Attachments (2)
Change History (8)
by , 9 years ago
| Attachment: | 0001-hvif2png-fix-for-builds-on-MacOS-X.patch added |
|---|
comment:1 by , 9 years ago
| patch: | 0 → 1 |
|---|
comment:2 by , 9 years ago
comment:3 by , 9 years ago
Hi Ingo; thanks for the help -- those suggestions are included in a new patch.
comment:4 by , 9 years ago
Save for the indentation in BuildSetup (spaces instead of tabs) the patch looks good to me. Anyone with an OS X host around to verify that it doesn't break the regular build?
by , 9 years ago
| Attachment: | 0001-hvif2png-hvif2png-building-on-MacOS-X.patch added |
|---|
Note:
See TracTickets
for help on using tickets.
I'd omit the
Glob-- it doesn't really matter, if a search path doesn't exist -- and move the two assignments to a preexisting if block which looks cozy.In the Jamfile please leave things like before and just add
$(HOST_LIBSUPC++)unconditionally.