Opened 4 years ago

Closed 4 years ago

#12226 closed task (fixed)

hvif2png Building on MacOS-X

Reported by: apl-haiku Owned by: apl-haiku
Priority: normal Milestone: Unscheduled
Component: Build System Version: R1/Development
Keywords: hvif2png Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

The hvif2png tool was not building on MacOS-X. I am using mac-ports to get the libpng library in so have added path elements to the libs and includes for macports libpng and also had to make a small change to the linking args. I'm a bit new to jam etc... but hopefully these changes are in the right places.

Attachments (2)

0001-hvif2png-fix-for-builds-on-MacOS-X.patch (1.5 KB ) - added by apl-haiku 4 years ago.
0001-hvif2png-hvif2png-building-on-MacOS-X.patch (1.3 KB ) - added by apl-haiku 4 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 by apl-haiku, 4 years ago

Has a Patch: set

comment:2 by bonefish, 4 years ago

I'd omit the Glob -- it doesn't really matter, if a search path doesn't exist -- and move the two assignments to a preexisting if block which looks cozy.

In the Jamfile please leave things like before and just add $(HOST_LIBSUPC++) unconditionally.

comment:3 by apl-haiku, 4 years ago

Hi Ingo; thanks for the help -- those suggestions are included in a new patch.

comment:4 by bonefish, 4 years ago

Save for the indentation in BuildSetup (spaces instead of tabs) the patch looks good to me. Anyone with an OS X host around to verify that it doesn't break the regular build?

comment:5 by apl-haiku, 4 years ago

OK those spaces / tabs should be corrected now.

comment:6 by waddlesplash, 4 years ago

Resolution: fixed
Status: newclosed

Applied in hrev49455. Thanks!

Note: See TracTickets for help on using tickets.