Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#12273 closed enhancement (fixed)

[Interface Kit] alert windows are too wide

Reported by: diver Owned by: axeld
Priority: high Milestone: R1/beta1
Component: Kits/Interface Kit Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description (last modified by diver)

hrev49497.

It seems that when in hrev49481 BAlert made its transition to layout API it has also changed the way alert windows look. Would it be possible to make them tidy again?

Old look: New look:

Note that Sceenshot doesn't capture window borders of alert windows -- #11368.

Attachments (2)

alert_old.png (9.5 KB) - added by diver 4 years ago.
alert_new.png (11.8 KB) - added by diver 4 years ago.

Download all attachments as: .zip

Change History (9)

Changed 4 years ago by diver

Attachment: alert_old.png added

Changed 4 years ago by diver

Attachment: alert_new.png added

comment:1 Changed 4 years ago by diver

Description: modified (diff)

comment:2 Changed 4 years ago by waddlesplash

Milestone: UnscheduledR1/beta1
Priority: normalhigh

comment:3 Changed 4 years ago by humdinger

Is this really a high prio beta-blocker?

comment:4 Changed 4 years ago by waddlesplash

Resolution: fixed
Status: newclosed

Fixed in hrev49505.

comment:5 Changed 4 years ago by axeld

I don't agree with this, actually. This is why I made it the way it was. Why should it use different spacing than what is used everywhere else?

Alerts are very small anyway, so there is no reason to make them that crowded. I'd like to see that reverted or at least come up with an argument why it should use that spacing other than "that is how it used to look".

comment:6 Changed 4 years ago by jua

It would be nice though to give the buttons an identical width again, which looks nicer IMO. Having them generally a bit wider is not bad as well (like in the old version), it makes them easier click targets.

comment:7 Changed 4 years ago by pulkomandy

Keeping the text top-aligned with the icon as in the "old" look looks better to me. I don't mind some extra spacing, however.

Note: See TracTickets for help on using tickets.