Opened 4 years ago

Closed 3 years ago

#12539 closed enhancement (fixed)

TextSearch won't grep XHTML files

Reported by: humdinger Owned by: nobody
Priority: normal Milestone: Unscheduled
Component: Applications/TextSearch Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

This is hrev49934.

XHTML has unfortunately a MIME type of application/xhtml+xml. You'd have to uncheck TextSearch's setting "Text files only" (which is what you usually want) to make it work.

TextSearch examines files, if they have a "text" supertype for this.
Would introducing this exception in code be acceptable:

// Make an exception for XHTML files
if (strcmp("application/xhtml+xml", mimeTypeString) == 0)
	return true;

(inserted here: http://xref.plausible.coop/source/xref/haiku/src/apps/text_search/FileIterator.cpp#61)

Change History (4)

comment:1 by waddlesplash, 4 years ago

Owner: changed from waddlesplash to nobody
Status: newassigned

deassigning various things from me

comment:2 by humdinger, 3 years ago

So... is the above solution OK for now?
I know an even better idea would be to check the "supported types" of TextSearch. OTOH, there probably aren't that many more text files that aren't of the MIME text/* in the future. Plus, as TextSearch comes from a package and is therefore read-only, the user can't add more supported types (which is something that might be addressed after R1, I guess).

comment:3 by pulkomandy, 3 years ago

Yes, that sounds like the right way to go.

comment:4 by humdinger, 3 years ago

Resolution: fixed
Status: assignedclosed

Applied in hrev50568.

Note: See TracTickets for help on using tickets.