Opened 4 years ago

Closed 3 years ago

#12589 closed bug (fixed)

Default button look changed for the worse

Reported by: axeld Owned by: axeld
Priority: blocker Milestone: R1/beta1
Component: Kits/Interface Kit Version: R1/Development
Keywords: Cc: looncraz
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

Since looncraz's changes, the color of the border around the default button looks quite ugly. Please revert to its previous appearance.

Attachments (2)

BButton-Default-Appearance.patch (2.3 KB) - added by looncraz 4 years ago.
BButton-Default-Appearance-2.patch (2.4 KB) - added by looncraz 4 years ago.
Using B_CONTROL_BORDER_COLOR

Download all attachments as: .zip

Change History (7)

comment:1 Changed 4 years ago by waddlesplash

Priority: normalblocker

Also, menu fields now have a 1px white border, too.

comment:2 Changed 4 years ago by looncraz

Change the control highlight color to 172, 172, 172, this will then be pixel-perfect with the previous appearance.

This could also be made the new default value for the color.

Changed 4 years ago by looncraz

comment:3 Changed 4 years ago by looncraz

Has a Patch: set

comment:4 in reply to:  3 Changed 4 years ago by looncraz

Replying to looncraz:

Changes default control highlight color to 172, 172, 172. This color is used by some applications (such as the virtual memory preflet for the slider color) and is, as such, not a perfect solution.

The next alternative is to actually use the control border color and change its default value to 172, 172, 172.

As such, the patch here should be considered just one option. I'll create another patch that uses the control border color.

Changed 4 years ago by looncraz

Using B_CONTROL_BORDER_COLOR

comment:5 Changed 3 years ago by pulkomandy

Resolution: fixed
Status: newclosed

Applied (the second one) in hrev50052.

Note: See TracTickets for help on using tickets.