#12628 closed bug (fixed)
[regression] BBox title text has white edges
| Reported by: | waddlesplash | Owned by: | looncraz |
|---|---|---|---|
| Priority: | blocker | Milestone: | R1/beta1 |
| Component: | Kits/Interface Kit | Version: | R1/Development |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
Essentially the same problem as the Deskbar Clock bug.
Attachments (1)
Change History (9)
comment:2 by , 8 years ago
| Cc: | removed |
|---|---|
| Owner: | changed from to |
| Status: | new → assigned |
by , 8 years ago
| Attachment: | Patch-12628.patch added |
|---|
Sets BBox low color properly for legacy applications.
comment:3 by , 8 years ago
| patch: | 0 → 1 |
|---|
comment:4 by , 8 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Applied in hrev50421. Thanks!
follow-up: 8 comment:7 by , 8 years ago
Replying to diver:
Sorry, I meant Beezer.
Hmm, I see that. I think those are BStringViews... I will dig into that in a few hours. If I find it is something different (seems so), I'll make a ticket and patch and reference it here.
comment:8 by , 8 years ago
Note:
See TracTickets
for help on using tickets.
I won't have time to address this in a proper patch for a while (I have to repair my virtualization setup after a system upgrade), but I believe the fix would be to change BBox::AttachedToWindow() to have the following:
AdoptParentColors();
if(Parent() == NULL [OR] ViewColor() == B_TRANSPARENT_COLOR)
It has something that *almost* does that at this time, but it doesn't take into account a potentially NULL parent.
In addition, changing the SetViewUIColor(B_PANEL_BACKGROUND_COLOR); line (662) to AdoptSystemColors() would probably be a good idea.