Opened 3 years ago

Closed 3 years ago

#12868 closed bug (fixed)

White background behind text in Beezer

Reported by: looncraz Owned by: stippi
Priority: normal Milestone: Unscheduled
Component: User Interface Version: R1/Development
Keywords: Cc: diver
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

The background behind "Store automatically" and "Restore automatically" should match the parent's view color.

http://files.looncraz.net/Beezer-bug.png

Bug initially reported by diver as a comment to ticket:12628

Attachments (1)

Patch-12868.patch (1.8 KB ) - added by looncraz 3 years ago.

Download all attachments as: .zip

Change History (4)

by looncraz, 3 years ago

Attachment: Patch-12868.patch added

comment:1 by looncraz, 3 years ago

Has a Patch: set

comment:2 by looncraz, 3 years ago

Beezer sets a grey low color manually on the string views which causes HasDefaultColors() to return false, which prevents AdoptParentColors() from being called.

I created a patch to move the problem to only affecting the text color, since it is more common for manual setting of string view colors to set the text color (or all the colors). The end result is that the affected BStringViews will always use black text, but I think only Beezer does this. If the code is available, it would be best to fix Beezer as well.

Last edited 3 years ago by looncraz (previous) (diff)

comment:3 by waddlesplash, 3 years ago

Resolution: fixed
Status: newclosed

Applied in hrev50433. Thanks!

If the code is available, it would be best to fix Beezer as well.

Yes, it is. https://github.com/HaikuArchives/Beezer

Note: See TracTickets for help on using tickets.