Opened 3 years ago

Closed 3 years ago

#12673 closed bug (fixed)

BColorControl: doublebuffering does not update slider colors

Reported by: rudolfc Owned by: jscipione
Priority: normal Milestone: Unscheduled
Component: Kits/Interface Kit Version: R1/Development
Keywords: BColorControl Backgrounds prefs Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

BColorControl has an error where the doublebuffered offscreen control bitmap is not updated: it's apparantly only drawn once. This error is revealed because of the way the Backgrounds prefs app works since pulkomandy's update(s) on dec 10 2014 and jan 6 2015, that is if you also modify backgrounds to use doublebuffering.

The problem can be easily fixed though. See first comment.

Change History (3)

comment:1 Changed 3 years ago by rudolfc

If you add a single line in the file: ColorControl.cpp, method BColorControl::Draw, line 375: when fBitmap exists, first call _InitOffscreen() before doing DrawBitmap(fBitmap, B_ORIGIN). I guess though the method _InitOffscreen() would better have another name now though..

Since I might hit the CodePolice or something, I gladly leave it upto someone else (not me) to update this class. thanks.

comment:2 Changed 3 years ago by jscipione

Owner: changed from axeld to jscipione
Status: newassigned

comment:3 Changed 3 years ago by jscipione

Resolution: fixed
Status: assignedclosed

Fixed in hrev50148

Note: See TracTickets for help on using tickets.