Opened 3 years ago

Closed 3 years ago

#12775 closed bug (fixed)

[Patch] BluetoothServer.cpp: fix gcc6 build

Reported by: mt Owned by: nobody
Priority: normal Milestone: Unscheduled
Component: Servers Version: R1/Development
Keywords: servers/bluetooth Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

In BluetoothServer::QuitRequested(), gcc6 x86_64 stops build with invalid conversion error, I think RemoveItemAt() may be used instead of RemoveItem() here.

C++ /home/haiku/haiku/haiku/generated64/objects/haiku/x86_64/release/servers/bluetooth/BluetoothServer.o 
/home/haiku/haiku/haiku/src/servers/bluetooth/BluetoothServer.cpp: In member function 'virtual bool BluetoothServer::QuitRequested()':
/home/haiku/haiku/haiku/src/servers/bluetooth/BluetoothServer.cpp:77:32: error: invalid conversion from 'int32 {aka int}' to 'LocalDeviceImpl*' [-fpermissive]
   fLocalDevicesList.RemoveItem((int32)0)) != NULL)
                                ^~~~~~~~
In file included from /home/haiku/haiku/haiku/src/servers/bluetooth/BluetoothServer.h:11:0,
                 from /home/haiku/haiku/haiku/src/servers/bluetooth/BluetoothServer.cpp:29:
/home/haiku/haiku/haiku/headers/os/support/ObjectList.h:510:1: note:   initializing argument 1 of 'bool BObjectList<T>::RemoveItem(T*, bool) [with T = LocalDeviceImpl]'
 BObjectList<T>::RemoveItem(T* item, bool deleteIfOwning)
 ^~~~~~~~~~~~~~

Attachments (2)

0022-BluetoothServer.cpp-fix-gcc6-build.patch (848 bytes ) - added by mt 3 years ago.
0022-BluetoothServer.cpp-fix-gcc6-build.2.patch (841 bytes ) - added by mt 3 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 by mt, 3 years ago

Has a Patch: set

comment:2 by korli, 3 years ago

Is "(int32)" still required?

in reply to:  2 comment:3 by mt, 3 years ago

Replying to korli:

Is "(int32)" still required?

Hi, korli. cast is not required, I update patch.

comment:4 by waddlesplash, 3 years ago

Resolution: fixed
Status: newclosed

Applied in hrev50308. Thanks!

Note: See TracTickets for help on using tickets.