Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#12958 closed bug (duplicate)

netfs Network icon only shows at 32X32

Reported by: bbjimmy Owned by: nobody
Priority: normal Milestone: Unscheduled
Component: File Systems/NetFS Version: R1/Development
Keywords: Cc:
Blocked By: #12069 Blocking:
Has a Patch: no Platform: All

Description

hrev50329

Install netfs from the Haiku repository.

Modify the netfs_mount script to work... copy the file out of bin to the Desktop, change the permissions so that one may write, open in Styled edit, add #!/bin/sh as line one and mark the file executable. Double-click the file. Now there is a Networkn icon on the Desktop or in the Disks, "/" folder. http://coquillemartialarts.com/jim/Network32.png icons at 32x32

change to icon view and change the icon size to anything other than 32x32 and the Network icon either is gone or looks like a TV display that is not properly synced.

http://coquillemartialarts.com/jim/network40.png icons at 40x40

I do not know what component is at fault as I could not locate the icon.

Attachments (5)

Device_Network_Harddisk (22.1 KB) - added by bbjimmy 3 years ago.
Network disk icon
Device_Network_Harddisk1 (36.0 KB) - added by bbjimmy 3 years ago.
another Network Disk icon
Device_Network_Harddisk1.2 (36.0 KB) - added by bbjimmy 3 years ago.
another Network Disk icon
Device_Networked_Harddisk.3 (26.9 KB) - added by bbjimmy 3 years ago.
Device_NAS.png (2.7 KB) - added by humdinger 3 years ago.
Device_NAS

Download all attachments as: .zip

Change History (24)

comment:1 Changed 3 years ago by pulkomandy

This is an "old style" BeOS bitmap icon. It is probably provided only at 32x32 and possibly 16x16. For other sizes, we need a vector icon instead.

comment:2 Changed 3 years ago by humdinger

But we do have scaling for old-style bitmap icons... See for example /bin/CortexAddOnHost.

Changed 3 years ago by bbjimmy

Attachment: Device_Network_Harddisk added

Network disk icon

Changed 3 years ago by bbjimmy

Attachment: Device_Network_Harddisk1 added

another Network Disk icon

Changed 3 years ago by bbjimmy

Attachment: Device_Network_Harddisk1.2 added

another Network Disk icon

comment:3 Changed 3 years ago by bbjimmy

We should use one of these:

http://coquillemartialarts.com/jim/NetworkIcons.png

icons attatched, sory for the third file, my Internet connection bonked out and I wasn't sure it was saved.

comment:4 Changed 3 years ago by bbjimmy

The icon seems to be here: http://cgit.haiku-os.org/haiku/tree/src/kits/tracker/TrackerIcons.rdef listed as

resource(R_ShareIcon) #'ICON' array

can we just replace this with a vicon ?

comment:5 Changed 3 years ago by miqlas

bbjimmy, could we get a HDD icon just with the globe? IT would be a bit better, i think.

comment:6 Changed 3 years ago by bbjimmy

This one might be ok?

http://coquillemartialarts.com/jim/another_icon.png

Changed 3 years ago by bbjimmy

Attachment: Device_Networked_Harddisk.3 added

comment:7 Changed 3 years ago by diver

Blocked By: 12069 added
Resolution: duplicate
Status: newclosed

comment:8 Changed 3 years ago by humdinger

WRT the icon, I don't think using a version of the harddisk icon (maybe with an overlay) is quite consistent. Harddisk + overlay is currently used to indicate local drives (boot drive, nighlty boot drive, BeOS drive, Zeta drive etc.). The network drive is normally just a shared folder. I committed an icon for NAS devices, which may fit the bill:

Device_NAS

Changed 3 years ago by humdinger

Attachment: Device_NAS.png added

Device_NAS

comment:9 Changed 3 years ago by bbjimmy

I think the icon should have some indication that it is networked. The world is being used in Haiku to represent a Network or that a file is used on the network ... IE html files. This icon does not indicate that it has anything to do with the network.

comment:10 Changed 3 years ago by axeld

I like it, and even if something more fitting in bbjimmy's opinion comes along, it's always only a single commit away :-)

comment:12 Changed 3 years ago by humdinger

For some reason, replacing
resource(R_ShareIcon) #'ICON' array { -- bitmapdata -- } and
resource(R_MICN_ShareIcon) #'MICN' array { -- bitmapdata -- }
with
resource(R_ShareIcon) #'VICN' array { --vectordata-- }
in TrackerIcons.rdef (and removing R_MICN_ShareIcon = 1051 from TrackerIcons.h) doesn't do the trick.
I now get the - I think - query icon...

Besides: Shouldn't it be investigated why the bitmap scaling doesn't work in this circumstance?
Maybe jscipione can look into it? IIRC he implemented the bitmap scaling.

comment:13 Changed 3 years ago by pulkomandy

The TrackerIcons are generic icons for when the device does not provide anything. The "query" icon is also used as the "generic volume" icon when nothing is available.

Getting the icon happens in kits/tracker/IconCache.cpp, which then requests it from kits/tracker/Bitmaps.cpp:144 (GetIconResource). This function does not attempt any scaling, and will just return an error if called with a size other than 16 or 32. It does handle vector icons, however, so I'm surprised that doesn't work.

comment:14 Changed 3 years ago by humdinger

It may be that this shared-icon doesn't work for my NFS4 mounted share...
I uploaded the built Tracker+lib to my Dropbox. Maybe bbjimmy can give it a try to see if the new vector icon appears for him.

Before starting the Tracker from that package, you have to "launch_roster stop x-vnd.be-trak" to prevent the launch_damon from restarting the old system Tracker. Restart with "launch_roster start x-vnd.be-trak".

comment:15 Changed 3 years ago by bbjimmy

This is slightly better, now it shows a vicon, just not the one expected:

http://coquillemartialarts.com/jim/screenshot5.png

Last edited 3 years ago by bbjimmy (previous) (diff)

comment:16 Changed 3 years ago by bbjimmy

looking at libtracker.so with QuickRes, R-Shareicon looks like the query icon.

resource(R_ShareIcon) #'VICN' array { --vectordata-- } Are you sure you put the right vectordata in the source?

comment:17 Changed 3 years ago by humdinger

I was sure that I pasted the correct rdef data, but now that you point it out... I managed to mess the copy&paste up. Damn! I'm committing the correct change momentarily... Thanks!

comment:18 Changed 3 years ago by axeld

So can we close this now?

comment:19 Changed 3 years ago by humdinger

It already is closed as duplicate. :)
There are other tickets dealing with the underlying issue of messed up scaled bitmap icons.

Note: See TracTickets for help on using tickets.