[People] don't disappear from Deskbar on close

[diver]

People don't disappear from Deskbar on window close.

[karma]

I've found that the following code leaves "count" at 0, so none of the windows are posting QUIT_REQUESTED to be_app in the end (PeopleWindow.cpp, line 201):

        while ((window = (TPeopleWindow *)be_app->WindowAt(index++))) {
                if (window->FindView("PeopleView"))
                        count++;
        }

I'm still debugging to find out what's happening behind the curtains.

[korli]

Can you reproduce this on R5 too ? I would assume the People application is working OK on BeOS R5 and Haiku misbehaves here.

[karma]

I don't have R5 at hand now, but neither does LaunchBox close when it should.

And it's because WindowAt doesn't work. There's a dynamic_cast<BWindow*> in _WindowAt in kits/app/Application.cpp, which should return a BWindow* pointer if it has found a window, but it always returns NULL.

I'm struggling to find an explanation for this - I was going to file a bug soon anyway.

[kaoutsis]

Replying to korli:

Can you reproduce this on R5 too ? I would assume the People application is working OK on BeOS R5 and Haiku misbehaves here.

Tested with hrev21757 and i can confirm that People is working OK on hrev5; btw: i will attached the src_apps_people_Jamfile.diff that adds hrev5 support to People app.

[karma]

This fixes the bug. (also fixes Launchbox, and the WindowAt function in general)

[kaoutsis]

src_apps_people_Jamfile.diff: buld People app for TARGET_PLATFORM=hrev5 also (this version is putting back the resources file)

[kaoutsis]

Tested with hrev21803: it's fixed.