Opened 3 years ago

Last modified 3 years ago

#13183 assigned task

Add copy constructor for BStringRef

Reported by: owenca Owned by: nobody
Priority: normal Milestone: Unscheduled
Component: Kits/Support Kit Version: R1/Development
Keywords: BStringRef Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

http://pulkomandy.github.io/ #32: Add a copy constructor to BStringRef

Attachments (2)

0001-added-copy-constructor-for-BStringRef-PVS-issue-32.patch (1.1 KB ) - added by owenca 3 years ago.
BStringRef.png (39.2 KB ) - added by owenca 3 years ago.
testing

Download all attachments as: .zip

Change History (5)

comment:1 by owenca, 3 years ago

Has a Patch: set

by owenca, 3 years ago

Attachment: BStringRef.png added

testing

comment:2 by pulkomandy, 3 years ago

I have deprecated this API because it is not needed, however, the class was kept for binary compatibility. I think it should not be allowed to keep a BStringRef, so I would make the copy constructor private and consider removing the operator= if possible (it is usually not used, since the reference is often converted to a char or to a pointer to the string internal data?).

comment:3 by axeld, 3 years ago

Owner: changed from axeld to nobody
Status: newassigned
Note: See TracTickets for help on using tickets.