Opened 9 months ago

Closed 9 months ago

#13194 closed enhancement (fixed)

Repository preflet code changes

Reported by: Brian Hill Owned by: Nobody
Priority: normal Milestone: Unscheduled
Component: Preferences Version: R1/Development
Keywords: Repositories preflet Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

Changes to code for Repositories preflet suggested by M. Lotz: Switch case bracket formatting Using BUrl class for validating and comparing URLs Move function declarations above variables in header files Use brackets for if statement conditions that extend more than one line Declare each variable seperately Exit a loop after condition met Modify emptying the ColumnListView

Attachments (2)

Repository_updates.patch (21.1 KB) - added by Brian Hill 9 months ago.
Repository code updates
0001-Suggested-changes-by-M.-Lotz.patch (20.1 KB) - added by Brian Hill 9 months ago.
Without while changes

Download all attachments as: .zip

Change History (5)

Changed 9 months ago by Brian Hill

Attachment: Repository_updates.patch added

Repository code updates

comment:1 Changed 9 months ago by Brian Hill

Has a Patch: set

comment:2 Changed 9 months ago by waddlesplash

The while loop at the end of the patch should keep its {{{!= NULL}} as per coding guidelines.

Changed 9 months ago by Brian Hill

Without while changes

comment:3 Changed 9 months ago by PulkoMandy

Resolution: fixed
Status: newclosed

Applied in hrev50868.

Note: See TracTickets for help on using tickets.