Opened 8 years ago

Closed 8 years ago

#13194 closed enhancement (fixed)

Repository preflet code changes

Reported by: perelandra Owned by: nobody
Priority: normal Milestone: Unscheduled
Component: Preferences Version: R1/Development
Keywords: Repositories preflet Cc:
Blocked By: Blocking:
Platform: All

Description

Changes to code for Repositories preflet suggested by M. Lotz: Switch case bracket formatting Using BUrl class for validating and comparing URLs Move function declarations above variables in header files Use brackets for if statement conditions that extend more than one line Declare each variable seperately Exit a loop after condition met Modify emptying the ColumnListView

Attachments (2)

Repository_updates.patch​ (21.1 KB ) - added by perelandra 8 years ago.
Repository code updates
0001-Suggested-changes-by-M.-Lotz.patch​ (20.1 KB ) - added by perelandra 8 years ago.
Without while changes

Download all attachments as: .zip

Change History (5)

by perelandra, 8 years ago

Attachment: Repository_updates.patch​ added

Repository code updates

comment:1 by perelandra, 8 years ago

patch: 0 → 1

comment:2 by waddlesplash, 8 years ago

The while loop at the end of the patch should keep its {{{!= NULL}} as per coding guidelines.

by perelandra, 8 years ago

Attachment: 0001-Suggested-changes-by-M.-Lotz.patch​ added

Without while changes

comment:3 by pulkomandy, 8 years ago

Resolution: → fixed
Status: new → closed

Applied in hrev50868.

Note: See TracTickets for help on using tickets.