First DHCP lookup times out when to connecting to WIFI

[tqh]

When connecting to wifi, first DHCP lookup fails. As its timeout is four seconds, it takes a long time to connect.

Not sure why it fails, probably fails to send first packets. I made a patch to DHCP which timeouts after a few mS and it connects four seconds faster.

[tqh]

Very short initial timeout

[tqh]

Patch should not be applied as is, only to show how it was tested.

[axeld]

Would be nice to find the cause of the first failure, but there is little that speaks against using a more aggressive retry interval here. It's used to reduce the load of the server when many clients going through a DHCP negotiation at once -- since current hardware is much more capable, and since this happens quite rarely anyway, I'm all for a shorter cycle.

[tqh]

Yes, not sure how to track the failure down easily though. If anyone can check if it also fails on first try on cable (I don't have hardware) we'd have some more clues.

[tqh]

Proposing these changes to dhcp-client, I changed the max comparison to a min one as it just seemed wrong to me.

[tqh]

Updated with header

[tqh]

We are getting 'Operation timed out' but bytes received are not < 0 here: ​http://cgit.haiku-os.org/haiku/tree/src/servers/net/DHCPClient.cpp#n683

So no if case is taken.

[tqh]

Oh, errno is not updated on success.

[tqh]

DHCP timeouts changed in hrev51039.

[waddlesplash]

Remaining issues tracked in #14307.

[nielx]

Assign tickets with status=closed and resolution=fixed within the R1/beta2 development window to the R1/beta2 Milestone