#13599 closed bug (fixed)

[Patch] media/BufferConsumer.cpp: Fix ordered comparison between pointer and zero

Reported by: mt Owned by: Barrett
Priority: normal Milestone: Unscheduled
Component: Kits/Media Kit Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

Since 'group' is pointer, I think comparison at line 272 may be replaced to null pointer check.

http://cgit.haiku-os.org/haiku/tree/src/kits/media/BufferConsumer.cpp#n272

/home/haiku/haiku/haiku/src/kits/media/BufferConsumer.cpp:272:12: error: ordered comparison between pointer and zero ('BBufferGroup *' and 'int')
        if (group > 0) {
            ~~~~~ ^ ~

Attachments (1)

0031-BufferConsumer.cpp-Fix-ordered-comparison-between-po.patch (774 bytes) - added by mt 22 months ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 22 months ago by mt

Has a Patch: set

comment:3 Changed 22 months ago by pulkomandy

Resolution: fixed
Status: newclosed

Applied in hrev51281. Thanks!

Note: See TracTickets for help on using tickets.