Opened 7 years ago
Closed 7 years ago
#13598 closed bug (fixed)
[Patch] mail/AddressTextControl.cpp: Fix ordered comparison between pointer and zero
Reported by: | mt | Owned by: | czeidler |
---|---|---|---|
Priority: | normal | Milestone: | Unscheduled |
Component: | Applications/Mail | Version: | R1/Development |
Keywords: | Cc: | ||
Blocked By: | Blocking: | ||
Platform: | All |
Description
Since strstr() returns pointer or NULL, I think comparison at line 779 may be replaced null pointer check.
http://cgit.haiku-os.org/haiku/tree/src/apps/mail/AddressTextControl.cpp#n779
/home/haiku/haiku/haiku/src/apps/mail/AddressTextControl.cpp:779:37: error: ordered comparison between pointer and zero ('char *' and 'int') if (strstr(buffer, "email") <= 0) ~~~~~~~~~~~~~~~~~~~~~~~ ^ ~}}}
Attachments (1)
Change History (4)
by , 7 years ago
Attachment: | 0030-AddressTextControl.cpp-Fix-ordered-comparison-betwee.patch added |
---|
comment:1 by , 7 years ago
patch: | 0 → 1 |
---|
comment:2 by , 7 years ago
Note:
See TracTickets
for help on using tickets.
Patch LGTM