[MediaPlayer] media extractor thread uses 100% cpu

[diver]

hrev51305 x86_64

​http://podtrac.com/pts/redirect.mp3/latenightlinux.com/media/LNL15.ogg

Playing this file is either makes MediaPlayer (media extractor thread) use 100% cpu or quits with:

pure virtual method called
terminate called without an active exception

[korli]

What about hrev51306?

[diver]

CPU usage is still high. Can't trigger the crash tho.

[korli]

https://dev.haiku-os.org/attachment/ticket/13410/VanillaFudge.mp3 seems to also be affected. MediaPlayer (or something it calls) seems to insist on extracting video frames which are not present.

[vidrep]

Note that the the slider of the progress bar never moves while playing that ogg sample clip.

[waddlesplash]

High CPU usage fixed in hrev52358; however, the time indicator still does not increment on these files.

[pulkomandy]

Still getting high CPU usage on some files here. In media player, "event queue runner", "playback manager", "media extractor thread" and "frame generator" threads are busy, as well as the main window thread.

How did we end up with so many threads just to play a media file anyway?

[leavengood]

Probably more of a MediaPlayer bug than Media Kit, though I don't know for sure yet. Probably the same issue as #15220.

[vidrep]

Moving to Beta 2 milestone as discussed on IRC.

[pulkomandy]

​https://review.haiku-os.org/c/haiku/+/2551

[waddlesplash]

Fix merged in hrev54121.

[vidrep]

Tested with hrev54121x86_64. Problem is still there. One CPU core at 100% and no progress bar movement or time count.

[pulkomandy]

​https://review.haiku-os.org/c/haiku/+/2562

[vidrep]

I applied the patch on both 32 and 64 bit. There is a definite difference in behaviour between the two. As a side note, the patch seems to fix a streaming issue that has existed for some time

https://dev.haiku-os.org/ticket/14147#comment:11

[waddlesplash]

Ticket retargeted after milestone closed

[ttcoder]

Congrats on a solid second beta release! Something I've been wondering: there's been talk of releasing updates in the beta2 update channel in the future. For instance, let's say pulkomandy's patchset 2562 above is applied to trunk, then backported to beta2 branch. I guess this ticket's milestone will remain at "beta3" since there is no "b2.1" milestone, we should still leave it to the haiku core Haiku devs to set milestones, right? And requests for backports to the beta2 branch should be made as polite messages rather than tweaking ticket fields then. 8-)

[waddlesplash]

Yes, we did backport patches to beta1 for a few months last time, and we will probably do the same again this time.

[pulkomandy]

Patch applied in hrev54577. There are still problems (the cover art is not displayed now, we get a black window instead) but no 100% CPU usage anymore, at least.