Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#13645 closed bug (fixed)

buildbot slaves configuration

Reported by: korli Owned by: kallisti5
Priority: normal Milestone:
Component: Sys-Admin Version:
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

Please fix the buildbot configuration for these slaves.

http://buildbot.haiku-os.org/buildslaves/kallisti5-fedora01 http://buildbot.haiku-os.org/buildslaves/kallisti5-fedora02

"Your umask is too restrictive (should be: <= 0022; is actually: 0077)"

https://www.freelists.org/post/haiku-commits/haiku-hrev51324,1

Change History (9)

comment:1 by kallisti5, 2 years ago

Sure.

  • 077 (as-is, Fedora 21)
    • New File: rw-------
    • New Dir: rwx------
  • 022 (new minimum in configure script)
    • New File: rw-r--r--
    • New Dir: rwxr-xr-x
  • 002 (Fedora default as of F26)
    • New File: rw-rw-r--
    • New Dir: rwxrwxr-x

Weird... the default is 022:

# By default, we want umask to get set. This sets it for non-login shell. # Current threshold for system reserved uid/gids is 200 # You could check uidgid reservation validity in # /usr/share/doc/setup-*/uidgid file if [ $UID -gt 199 ] && [ "id -gn" = "id -un" ]; then

umask 002

else

umask 022

fi

comment:2 by kallisti5, 2 years ago

Looks like I was starting the buildslave via a cron entry:

@reboot	buildslave start /var/lib/buildbot/slaves/haiku

Going to convert to a systemd service:

# cat /etc/systemd/system/buildbot-slave.service 
[Unit]
Description=BuildBot slave service
After=network.target

[Service]
User=bbot
Group=bbot
Type=forking
WorkingDirectory=/home/bbot
ExecStart=/bin/buildslave start /var/lib/buildbot/slaves/haiku

[Install]
WantedBy=multi-user.target

systemd defaults to 022

Last edited 2 years ago by kallisti5 (previous) (diff)

comment:3 by kallisti5, 2 years ago

It looks like geist's builder on Ubuntu is encountering the same issue: http://buildbot.haiku-os.org/builders/haiku-repository-x86_64/builds/3499

I wonder if he is spawning it via a one-liner cron entry as well?

comment:4 by korli, 2 years ago

waddlesplash spoke specifically of a buildbot slave tac config file.

comment:5 by korli, 2 years ago

[18:24:27] <PulkoMandy> geist: we need to set umask to 022 in buildbot.tac on the slaves

comment:6 by kallisti5, 2 years ago

Resolution: fixed
Status: newclosed

Done. Was set to "None" on my slaves.

comment:7 by korli, 2 years ago

Thanks!

comment:8 by pulkomandy, 2 years ago

A little background: the default in unix is indeed 0022, but twistd (the thing used to daemonize buildbot) forces it to 0077 by default. So it needs to be restored from inside the buildbot environment, which can be done using the setting in buildbot.tac.

We initially didn't notice the problem, and when we did, we updated the template buildbot.tac used to create new slaves, but old ones stayed as is.

comment:9 by korli, 2 years ago

FYI it seems the last buildbot slave is now fixed (configured and restarted).

Note: See TracTickets for help on using tickets.