BTabView tabs side parameter

[KapiX]

This is tracking ticket for changes related to adding tabs side parameter to BTabView.

I took a look at BTabView code and decided to clean it up a bit first.

Patch and screenshot attached.

[KapiX]

left - new, right - current

[KapiX]

Tabs on all sides

[pulkomandy]

cc1plus: warnings being treated as errors
/Git/haiku/haiku/src/kits/interface/TabView.cpp: In method `void BTab::DrawLabel(BView *, BRect)':
/Git/haiku/haiku/src/kits/interface/TabView.cpp:278: warning: `float rotation' might be used uninitialized in this function
/Git/haiku/haiku/src/kits/interface/TabView.cpp: In method `void BTab::DrawTab(BView *, BRect, tab_position, bool = true)':
/Git/haiku/haiku/src/kits/interface/TabView.cpp:321: warning: `uint32 borders' might be used uninitialized in this function
/Git/haiku/haiku/src/kits/interface/TabView.cpp: In method `class BRect BTabView::DrawTabs()':
/Git/haiku/haiku/src/kits/interface/TabView.cpp:886: warning: `uint32 borders' might be used uninitialized in this function

[KapiX]

It never showed me those. Not even warnings. I found out why: I had DEBUG set for kits directory. Bug?

[pulkomandy]

Yes, I think gcc2 is not noticing that the if/switches in fact cover all possible cases.

Applied in hrev51368 and I forced initialization of the variables.

[KapiX]

I mean a bug in build system. I have built the code with gcc2 except I had DEBUG enabled and it didn't emit any warnings. When I disabled DEBUG it suddenly fails with errors above.