Registrar died while compiling "doodle" sample app.

[jackburton]

With hrev21867, I installed the R5 development tools under haiku, and tried to compile the "doodle" sample app in optional/sample-code/intro.

The actual compiling and linking works fine, but when mimesetting the binary, registrar crashed. Since it crashes in BMessage, I assume it's a BMessage bug. It's 100% reproducible. Included is the backtrace.

[mmlr]

The cause was that the size of a message item was not swapped when the swapped BMessage format was used. This caused the message to try to allocate 640MB instead of 40Bytes which failed. By the way the flat message is hidden in the Doodle resource file which was apparently made on a PPC BeOS. A simple "mimeset -f Doodle" on a already built app would have caused the same crash. Fixed in hrev21901.

[jackburton]

Replying to mmlr:

The cause was that the size of a message item was not swapped when the swapped BMessage format was used. This caused the message to try to allocate 640MB instead of 40Bytes which failed.

Interesting. I think Registrar shouldn't die anyway in that case, what do you think?

[mmlr]

Replying to jackburton:

Interesting. I think Registrar shouldn't die anyway in that case, what do you think?

Yes it shouldn't. I have fixed our realloc() wrapper in this regard and it does now not try to memcpy() if the allocation failed. BMessage should handle the error correctly, but I still have to investigate what happens when you use the BMessage where a reallocation failed though.