BCalendarView: use bold for 'today'

[humdinger]

This is hrev51428.

I use different colours for selected lists/menus: white on blue. The current day ('today') in BCalendarView uses keyboard_navigation_color(), which is also blue. It's difficult to read when 'today' is selected:

The attached patch uses a bold font face instead, and only keyboard_navigation_color() when 'today' isn't selected:

[humdinger]

old calendar

[humdinger]

new calendar

[humdinger]

patch

[pulkomandy]

Sounds good.

The keyboard navigation color should only be used for keyboard navigation (in the case of calendar, you can navigate to a different day using arrow keys, and select it then by pressing space). So it shouldn't be forced on the current day, I think, but used only for the day which has keyboard focus (try the arrow keys to experiment this). Having the current day in bold should be enough, no need to change colors at all.

This leaves us with:

• current day: bold
• selected day: uses list selection colors (both text and background)
• keyboard focus: keyboard navigation color for the border, (and possibly the text?)

I checked what Android does, on my smartphone, the whole calendar is slightly darker than white, which allows the current day to be highlight in white.

[axeld]

I'd prefer to have the background of the current date to be highlighted; either like Android does, or slightly darker than the rest would work for me, too.

I agree with Adrien about the use of keyboard navigation color which also means that this patch is not complete to solve the issue (but could be applied in the mean time nonetheless).

[humdinger]

new patch, incorporating this ticket's comments

[humdinger]

See the updated patch attached. I hope everthing is now drawn according to your feedback.
I was only easily able to view my changes in a newly built Time prefs. Not sure how to quickly check with the calender available from the Deskbar...

[humdinger]

Applied with hrev51431 (sans coding style violation spotted by Rene, thanks!)