Opened 2 years ago

Closed 2 years ago

#13714 closed enhancement (fixed)

BCalendarView: use bold for 'today'

Reported by: humdinger Owned by: nobody
Priority: normal Milestone: Unscheduled
Component: Kits Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

This is hrev51428.

I use different colours for selected lists/menus: white on blue. The current day ('today') in BCalendarView uses keyboard_navigation_color(), which is also blue. It's difficult to read when 'today' is selected:

old calendar

The attached patch uses a bold font face instead, and only keyboard_navigation_color() when 'today' isn't selected:

new calendar

Attachments (4)

calender_old.png (6.3 KB) - added by humdinger 2 years ago.
old calendar
calender_new.png (6.3 KB) - added by humdinger 2 years ago.
new calendar
0001-BCalendarView-use-bold-for-today.patch (1.9 KB) - added by humdinger 2 years ago.
patch
0001-BCalendarView-change-visuals-for-today.patch (2.7 KB) - added by humdinger 2 years ago.
new patch, incorporating this ticket's comments

Download all attachments as: .zip

Change History (11)

Changed 2 years ago by humdinger

Attachment: calender_old.png added

old calendar

Changed 2 years ago by humdinger

Attachment: calender_new.png added

new calendar

Changed 2 years ago by humdinger

patch

comment:1 Changed 2 years ago by humdinger

Has a Patch: set

comment:2 Changed 2 years ago by pulkomandy

Sounds good.

The keyboard navigation color should only be used for keyboard navigation (in the case of calendar, you can navigate to a different day using arrow keys, and select it then by pressing space). So it shouldn't be forced on the current day, I think, but used only for the day which has keyboard focus (try the arrow keys to experiment this). Having the current day in bold should be enough, no need to change colors at all.

This leaves us with:

  • current day: bold
  • selected day: uses list selection colors (both text and background)
  • keyboard focus: keyboard navigation color for the border, (and possibly the text?)

I checked what Android does, on my smartphone, the whole calendar is slightly darker than white, which allows the current day to be highlight in white.

Last edited 2 years ago by pulkomandy (previous) (diff)

comment:3 Changed 2 years ago by axeld

I'd prefer to have the background of the current date to be highlighted; either like Android does, or slightly darker than the rest would work for me, too.

I agree with Adrien about the use of keyboard navigation color which also means that this patch is not complete to solve the issue (but could be applied in the mean time nonetheless).

comment:4 Changed 2 years ago by humdinger

Has a Patch: unset

Changed 2 years ago by humdinger

new patch, incorporating this ticket's comments

comment:5 Changed 2 years ago by humdinger

Has a Patch: set

comment:6 Changed 2 years ago by humdinger

See the updated patch attached. I hope everthing is now drawn according to your feedback.
I was only easily able to view my changes in a newly built Time prefs. Not sure how to quickly check with the calender available from the Deskbar...

comment:7 Changed 2 years ago by humdinger

Resolution: fixed
Status: newclosed

Applied with hrev51431 (sans coding style violation spotted by Rene, thanks!)

Note: See TracTickets for help on using tickets.