[package_daemon] Package problems window doesn't close

[diver]

Package problems window doesn't close after selecting a working solution and clicking Retry. Might be a problem with this change ​http://cgit.haiku-os.org/haiku/commit/src/servers/package?id=b105213b81b4536f6d06f4462f3e008ddc02808e

[perelandra]

How are you installing, HaikuDepot, opening a .hpkg file, SoftwareUpdater? Do you have a screenshot of window and what are you trying to install? That commit only made layout changes, no functional change.

[diver]

I open a .hpkg file. This is what I get after clicking Retry button. I moved Packaged problems window a bit lower to unhide Package changes window which has been completely hid by Package problems window.

[diver]

BTW, clicking Package changes window doesn't bring it to front, you have to close Package problems window first (by clicking tab close button) to get to the window behind it.

[perelandra]

I think this is an issue with the core logic of the package manager, not an issue with the GUI window. I haven't worked in the package manager code at all so someone else would probably be better to debug. Some things I notice though are:

1- You are downgrading? Not sure how that works.

2- Naming convention- perhaps the naming convention used of version 2.8-2 instead of something like 2.8.0-2 is messing up some logic.

And yes the window was made modal by my last changes, this is how it should be since you must choose an option to proceed. Being modal forces a choice.

[diver]

I'm downgrading just to show the problem, and it indeed works fine. It also happens when I'm upgrading, so it doesn't meter. I remember it was working in the beginning of the year, so it's a regression. I'm not saying that it was your changes tho :)

[perelandra]

It looks like bonefish has most of the package_daemon tickets. Is he/she still around? When I've seen the package problems window it usually works but I don't do a lot of packages in my dev environment so I see it rarely. It looks like you just released 2.8.1 so what you saw earlier in the year was with a different package update. So I suspect it is something specific with this package. I really don't know anything about dependency resolution though.

Does manually uninstalling the old version first, then installing the new one work?

[diver]

You can't uninstall freetype as haiku package depends on it but that doesn't matter. And this is in no way related to freetype as I've seen it with many other packages. freetype was just an example.

[korli]

perelandra, the "Package problems" window is now modal, whereas the "Package changes" window isn't, thus the "Package changes" window appears behind the "Package problems" window. Before your change, it could be that the "Package problems" window didn't close either, but the "Package changes" window appeared front, which made the problem not so obvious.

[miqlas]

I can say for sure it isn't freetype related as i've seen this also with different packages. Annoying.

[korli]

As of hrev51443, the "Package Problems" window is now hidden once a selection is done, the reason is the window is modal. Please check.

[diver]

Can't reproduce it anymore. Closing... Thanks!