Opened 6 years ago
Last modified 5 years ago
#13828 new enhancement
Implement new setlocale command
| Reported by: | KeyboardFire | Owned by: | nobody |
|---|---|---|---|
| Priority: | normal | Milestone: | Unscheduled |
| Component: | Applications/Command Line Tools | Version: | R1/Development |
| Keywords: | locale | Cc: | |
| Blocked By: | Blocking: | #13837 | |
| Platform: | All |
Description
This is a command line utility for setting the system locale, created for a Google Code-In task.
Attachments (8)
Change History (15)
comment:1 by , 6 years ago
| patch: | 0 → 1 |
|---|
by , 6 years ago
| Attachment: | 0002-Fix-style-in-setlocale.patch added |
|---|
by , 6 years ago
| Attachment: | 0003-Reduce-levels-of-nesting-in-setlocale.patch added |
|---|
by , 6 years ago
| Attachment: | 0004-Capitalize-output-of-setlocale.patch added |
|---|
by , 6 years ago
| Attachment: | 0001-Implement-new-setlocale-command.patch added |
|---|
comment:2 by , 6 years ago
- I saw some style guides violations and other strangeness (++i in for loop, for example, use of xor on booleans (!= should be used),)
- Command-line parsing should be done using getopt() and not ad-hoc code
- It would be better to use the usual language_country naming for languages (en_US, fr_FR, etc)
- Iterating over all languages to find the one we want to use is inefficient and useless, it is possible to create a BLanguage instance directly from the language and country code
- The code for listing languages and for setting a language should be separate (I would make them two different functions)
by , 6 years ago
| Attachment: | 0001-Link-the-setlocale-tool.patch added |
|---|
Path to add the tool into images
by , 6 years ago
| Attachment: | 0003-Statisfy-the-Coding-Guidelines.patch added |
|---|
Depends on 0002-Improve-argument-parsing.patch
by , 6 years ago
| Attachment: | 0003-Improve-the-setlocale-command.patch added |
|---|
Varios changes to make it complete. Depends on 0001-Implement-new-setlocale-command.patch
comment:3 by , 6 years ago
Ps.:
I ended up maintaing a clean commit history. The attached patch contains 0003-Statisfy-the-Coding-Guidelines.patch.
comment:4 by , 6 years ago
| patch: | 1 → 0 |
|---|
comment:6 by , 6 years ago
| Blocking: | 13837 added |
|---|
comment:7 by , 5 years ago
| Component: | - General → Applications/Command Line Tools |
|---|---|
| patch: | → 0 |
Note:
See TracTickets
for help on using tickets.
