Context Navigation

#13828 new enhancement

Reported by:	KeyboardFire	Owned by:	nobody
Priority:	normal	Milestone:	Unscheduled
Component:	Applications/Command Line Tools	Version:	R1/Development
Keywords:	locale	Cc:
Blocked By:		Blocking:	#13837
Platform:	All

This is a command line utility for setting the system locale, created for a Google Code-In task.

0002-Fix-style-in-setlocale.patch (4.1 KB ) - added by KeyboardFire 7 years ago.
0003-Reduce-levels-of-nesting-in-setlocale.patch (1.4 KB ) - added by KeyboardFire 7 years ago.
0004-Capitalize-output-of-setlocale.patch (827 bytes ) - added by KeyboardFire 7 years ago.
0001-Implement-new-setlocale-command.patch (4.3 KB ) - added by KeyboardFire 7 years ago.
0001-Link-the-setlocale-tool.patch (1.4 KB ) - added by lezsakdomi 7 years ago.: Path to add the tool into images
0002-Improve-argument-parsing.patch (5.1 KB ) - added by lezsakdomi 7 years ago.: Use getopt
0003-Statisfy-the-Coding-Guidelines.patch (5.5 KB ) - added by lezsakdomi 7 years ago.: Depends on 0002-Improve-argument-parsing.patch
0003-Improve-the-setlocale-command.patch (9.5 KB ) - added by lezsakdomi 7 years ago.: Varios changes to make it complete. Depends on 0001-Implement-new-setlocale-command.patch

Download all attachments as: .zip

patch:	0 → 1

Attachment:	0002-Fix-style-in-setlocale.patch added

Attachment:	0003-Reduce-levels-of-nesting-in-setlocale.patch added

Attachment:	0004-Capitalize-output-of-setlocale.patch added

Attachment:	0001-Implement-new-setlocale-command.patch added

I saw some style guides violations and other strangeness (++i in for loop, for example, use of xor on booleans (!= should be used),)
Command-line parsing should be done using getopt() and not ad-hoc code
It would be better to use the usual language_country naming for languages (en_US, fr_FR, etc)
Iterating over all languages to find the one we want to use is inefficient and useless, it is possible to create a BLanguage instance directly from the language and country code
The code for listing languages and for setting a language should be separate (I would make them two different functions)

Attachment:	0001-Link-the-setlocale-tool.patch added

Path to add the tool into images

Attachment:	0002-Improve-argument-parsing.patch added

Use getopt

Attachment:	0003-Statisfy-the-Coding-Guidelines.patch added

Depends on 0002-Improve-argument-parsing.patch

Attachment:	0003-Improve-the-setlocale-command.patch added

Varios changes to make it complete. Depends on 0001-Implement-new-setlocale-command.patch

Ps.:
I ended up maintaing a clean commit history. The attached patch contains 0003-Statisfy-the-Coding-Guidelines.patch.

patch:	1 → 0

patch:	0

Remaining patches migrated to Gerrit:

Blocking:	13837 added

Component:	- General → Applications/Command Line Tools
patch:	→ 0

Note: See TracTickets for help on using tickets.