Opened 7 years ago

Last modified 6 years ago

#13952 new bug

Make Icon-O-Matic usable from command line so that it can convert icons from IOM to HVIF/SVG

Reported by: owenca Owned by: stippi
Priority: normal Milestone: Unscheduled
Component: Applications/Icon-O-Matic Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Platform: All

Description

Usage:

Icon-O-Matic -[h|s] -o output_file IOM_file

It returns 0 if successful or 1 otherwise.

Attachments (3)

0001-Icon-O-Matic-convert-IOM-to-HVIF-SVG-from-command-li.patch (5.0 KB ) - added by owenca 7 years ago.
0001-Icon-O-Matic-convert-IOM-to-HVIF-RDef-Source-SVG-fro.patch (5.3 KB ) - added by owenca 7 years ago.
Replacing the previous patch.
0001-Icon-O-Matic-convert-IOM-to-HVIF-RDef-SVG-source-fro.patch (5.6 KB ) - added by owenca 7 years ago.
Replacing previous patches.

Download all attachments as: .zip

Change History (10)

comment:1 by bbjimmy, 7 years ago

Might as well add -R for RDef and -S for HVIF Source Code

comment:2 by mmu_man, 7 years ago

Hmm, I'd rather avoid using -h as it's traditionally used for help.

Also, you don't need to check for NULL before calling delete.

I don't see any reason to remove member init from the constructor, it's not like it creates any window.

in reply to:  1 comment:3 by owenca, 7 years ago

Replying to jim saxton:

Might as well add -R for RDef and -S for HVIF Source Code

Done. (I wasn't sure if there was a special reason that the GCI task didn't ask for these two formats.)

in reply to:  2 comment:4 by owenca, 7 years ago

Replying to François Revol:

Hmm, I'd rather avoid using -h as it's traditionally used for help.

Changed to -H. (I had the same concern, but after trying -h with mv/cp, I thought it was not the case anymore.)

Also, you don't need to check for NULL before calling delete.

Fixed. (I got it mixed up with double free in C.)

I don't see any reason to remove member init from the constructor, it's not like it creates any window.

The _Init() function creates two file panels and calls _RestoreSettings(). I wanted to bypass it for the command-line usage to make it run faster and to avoid any possible side effects unknown to me. If it's better to have the same constructor for both usage, I can put it back in.

by owenca, 7 years ago

Replacing the previous patch.

by owenca, 7 years ago

Replacing previous patches.

comment:5 by owenca, 7 years ago

Added help/usage.

comment:6 by pulkomandy, 7 years ago

Please submit patches to Gerrit instead of attaching them to the bugtracker.

comment:7 by waddlesplash, 6 years ago

Component: - GeneralApplications/Icon-O-Matic
Owner: changed from nobody to stippi
Note: See TracTickets for help on using tickets.