buildbot build broken

[korli]

It seems the usual Haiku build tasks now try to build the buildtools, which is unexpected:

​https://buildbot.haiku-os.org/builders/haiku-repository-x86_64/builds/3904/steps/compile%20x86_64%20tools/logs/stdio

../haiku/configure -j2 --build-cross-tools x86_64 ../buildtools
 in dir /home/builder/builds/haiku-repository-x86_64/../cross-tools-x86_64 

To compare with ​https://buildbot.haiku-os.org/builders/haiku-repository-x86_64/builds/3903 there is a new task at step 2.

[kallisti5]

I double checked the buildbot config, and nothing has changed recently.

Noticed the logic here was slightly flawed:

x86_64 crosstools already exist in /home/builder/builds/cross-tools-x86_64/cross-tools-x86_64; skipping build

../haiku/configure: line 234: /home/builder/builds/cross-tools-x86_64/cross-tools-x86_64/bin/x86_64-unknown-haiku-gcc: No such file or directory

It's a simple directory check to see if the toolchain is there. I improved it in hrev51825 to check for the directory, and for a compiler binary.

Lets see if that kicks things back. Nothing has changed recently, the thing that triggered the issue seems to be touching the build-cross-tools-gcc4 script.

[kallisti5]

aww yup. buildbot squats and watches those scripts for modifications and removes the binaries when messed with.

                        factory.addStep(
                                ShellCommand(
                                        command = dedent("""
                                                if ! cmp -s ../haiku/build/scripts/%(script)s \
                                                        ../trigger-files/%(haikuBranch)s/%(script)s; then
                                                        rm -f ../cross-tools-*/cross-tools-*/bin/*
                                                        mkdir -p ../trigger-files/%(haikuBranch)s
                                                        cp ../haiku/build/scripts/%(script)s \
                                                                ../trigger-files/%(haikuBranch)s/
                                                fi
                                                """[1:]) % {
                                                        'haikuBranch' : haikuBranch,
                                                        'script' : script,
                                                },
                                        description = ['check', script],
                                        name = 'check ' + script,
                                        workdir = Property('builddir'),
                                        hideStepIf = True))

hrev51825 should indeed work around the issue. I wonder if that buildbot logic should be removing the whole cross-tools-XXX directory and not just the bins?

[kallisti5]

this was fixed per hrev51825. There was an additional issue of baron being full. I just fixed that as well.

We need some code to cleanup nightly images on maui when we go live with it. (maybe keep even builds only after XX days or something)