Opened 4 months ago

Closed 4 months ago

#14329 closed task (invalid)

Review use of realloc in BMediaFile

Reported by: jackburton Owned by: Barrett
Priority: normal Milestone: Unscheduled
Component: Kits/Media Kit Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

In BMediaFile::CreateTrack() we are using realloc() to extend the BMediaTrack array. The behaviour of realloc is undefined for non-POD, since it just copies the memory, it doesn't call copy constructors of the contained objects, so it could cause problems.

Change History (1)

comment:1 Changed 4 months ago by jackburton

Resolution: invalid
Status: newclosed

My bad. We are only reallocating pointers, not objects.

Note: See TracTickets for help on using tickets.