Opened 3 years ago

Closed 18 months ago

Last modified 16 months ago

#14336 closed bug (fixed)

TextSearch won't accept "--with-..." as search terms

Reported by: KapiX Owned by: phoudoin
Priority: normal Milestone: R1/beta2
Component: Applications/TextSearch Version: R1/Development
Keywords: Cc:
Blocked By: #15650 Blocking:
Platform: All


It seems it's passing the term to grep unescaped, and grep fails with "unrecognized argument".

Change History (7)

comment:1 by phoudoin, 3 years ago

with Regular Expression enabled of not?

A quick check shows that grep -F "--with-..." works, but grep "--with-..." doesn't.

I guess when Regular Expression is enabled, the -e option should be explicitly passed then, as `grep -e "--with-..." works as expected.

  • (a) current vs. (b) proposed

    a b  
    272     if (! fRegularExpression)
    273         argv[argc++] = "-F"; // no a regexp: force fixed string,
     272    argv[argc++] = fRegularExpression ? "-e" : "-F";
Last edited 3 years ago by phoudoin (previous) (diff)

comment:2 by KapiX, 3 years ago

It doesn't work in both cases. Exact term: --with-theme in libreoffice's source directory.

comment:3 by phoudoin, 18 months ago

I guess the root cause was fixed in #15650. Could you check again?

comment:4 by phoudoin, 18 months ago

Blocked By: 15650 added

comment:5 by phoudoin, 18 months ago

Resolution: fixed
Status: newclosed

Closing, as I really believe this issue is a duplicate of #15650, which is fixed in hrev53758. Please re-open if the issue persists.

Last edited 18 months ago by phoudoin (previous) (diff)

comment:6 by KapiX, 18 months ago

Yes, it works now, thanks :)

comment:7 by nielx, 16 months ago

Milestone: UnscheduledR1/beta2

Assign tickets with status=closed and resolution=fixed within the R1/beta2 development window to the R1/beta2 Milestone

Note: See TracTickets for help on using tickets.