TextSearch: search string is not properly escaped when passing in grep

[X512]

This is hrev53732.

Steps to reproduce:

1. Open TextSearch in some directory
2. Enter ->Go( as search string and press search.
3. Following contents will be displayed multiple times in search results:

   grep: invalid option -- '>'
   Usage: grep [OPTION]... PATTERN [FILE]...
   Try 'grep --help' for more information.
   

[phoudoin]

Damn. Please someone can try if it will be fixed by adding these lines in Grepper.cpp:Grepper::_RunnerThread(), line 274:

Version

@@ -266 +266 @@
     // grep command driven by xargs dispatcher
     argv[argc++] = "grep";
     argv[argc++] = "-n"; // need matching line(s) number(s)
     argv[argc++] = "-H"; // need filename prefix
     if (! fCaseSensitive)
         argv[argc++] = "-i";
     if (! fRegularExpression)
         argv[argc++] = "-F";     // no a regexp: force fixed string, 
+    // Add double dash argument to tell grep 
+    // it's the end of commands options
+    argv[argc++] = "--";
     argv[argc++] = fPattern;
     argv[argc] = NULL;

? Thanks

[X512]

Fix confirmed.

I uploaded proposed fix to Gerrit: ​https://review.haiku-os.org/c/haiku/+/2149.

[phoudoin]

Thanks.

[phoudoin]

Possible duplicate: #14336

[nielx]

Assign tickets with status=closed and resolution=fixed within the R1/beta2 development window to the R1/beta2 Milestone