TextSearch won't accept "--with-..." as search terms

[KapiX]

It seems it's passing the term to grep unescaped, and grep fails with "unrecognized argument".

[phoudoin]

with Regular Expression enabled of not?

A quick check shows that grep -F "--with-..." works, but grep "--with-..." doesn't.

I guess when Regular Expression is enabled, the -e option should be explicitly passed then, as `grep -e "--with-..." works as expected.

​https://github.com/haiku/haiku/blob/master/src/apps/text_search/Grepper.cpp#L272

(a) current vs. (b) proposed

@@ -272 @@
-    if (! fRegularExpression)
-        argv[argc++] = "-F"; // no a regexp: force fixed string, 
+    argv[argc++] = fRegularExpression ? "-e" : "-F";

[KapiX]

It doesn't work in both cases. Exact term: --with-theme in libreoffice's source directory.

[phoudoin]

I guess the root cause was fixed in #15650. Could you check again?

[phoudoin]

Closing, as I really believe this issue is a duplicate of #1565, in hrev53758. Please re-open if the issue persist.

[KapiX]

Yes, it works now, thanks :)

[nielx]

Assign tickets with status=closed and resolution=fixed within the R1/beta2 development window to the R1/beta2 Milestone