BNotification and NotificationServer crash with OnClickRefs

[ahwayakchih]

BNotification crashes after calling Send with OnClickRefs added.

If application works that around by sending message with refs directly to the notification server, server will crash after user clicks on the NotificationView - AFAIK because it uses the same BNotification class internally.

Bug is located in the BNotification::OnClickRefAt method (​https://github.com/haiku/haiku/blob/21909dacd2349326e653981e5d7e78878ab49286/src/kits/app/Notification.cpp#L469). The code there looks like this:

	return (entry_ref*)fArgv.ItemAt(index);

It should look like this instead:

	return (entry_ref*)fRefs.ItemAt(index);

[waddlesplash]

Fixed in hrev52287. Thanks for reporting!

[ahwayakchih]

Thanks :).