#14439 closed bug (fixed)
Gerrit eMail missing
| Reported by: | nzimmermann | Owned by: | kallisti5 |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Website/Gerrit | Version: | |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
Hi, this is my first time trying to submit a patch to Haiku.
I got the error remote: ERROR: You have not registered any email addresses. when trying to push.
Per the instructions on the SubmittingPatches page, I'm asking here to get my email address set so I can push the patch for review.
My github username is "nikolaszimmermann" and my email should be "zimmermann at physik.rwth-aachen.de"
Thanks!
Change History (7)
comment:1 by , 6 years ago
comment:2 by , 6 years ago
I'm happy make this change at the wiki. While I'm at it, there's this item, too:
- Create patches from within the HAIKU_TOP directory. This is the directory that contains configure and typically is the haiku/ or buildtools/ branch.
Creating patches isn't really needed when using Gerrit, is it?
comment:3 by , 6 years ago
Yes, and this was already not a problem since we switched from SVN to Git anyways.
Maybe a link to Owen's Haiku-format is a good idea too (next to checkstyle and vim coding style checker)
I would also remove the "public humiliation" in the "configure git" section. Our mailing lists are not like that.
comment:4 by , 6 years ago
I would also remove the "public humiliation" in the "configure git" section. Our mailing lists are not like that.
It's more of a personally spawned self-reflection kind of "public humiliation", but yeah. Humdinger added that 6 years ago :-)
comment:5 by , 6 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
All done. Closing ticket as I assume Nicolas has solved his issue at Gerrit.
follow-up: 7 comment:6 by , 6 years ago
Not really, my problem is still persistent. I tried to add my eMail first to Gerrit, after logging in with my GitHub account. Gerrit told me a verification eMail was sent, but it never arrived.
I asked on IRC, and axeld pointed me to the instructions, which I followed.
Any further idea, why Gerrit doesn't mail me? :-)
comment:7 by , 6 years ago
Replying to nzimmermann:
Not really, my problem is still persistent. Any further idea, why Gerrit doesn't mail me? :-)
Funny, I've switched to the old UI and could simply select the eMail adress that I previously entered, without confirming some eMail. Anyhow, it worked fine, and I was able to upload my patch: https://review.haiku-os.org/#/c/haiku/+/515/
These instructions are out of date. You can now login to gerrit using your github account, go to your user settings and add the email address there yourself.