[Package Kit] some strings are not localized

[diver]

Some strings used in SoftwareUpdater are not yet localized.

​https://github.com/haiku/haiku/blob/master/src/kits/package/RefreshRepositoryRequest.cpp

"Fetching repository checksum from "
"Validating checksum for "
"Fetching repository-cache from "
"Activating repository cache for "

[nielx]

I'll have a look at this after B1 is released

[nielx]

See ​https://review.haiku-os.org/c/haiku/+/2329 for a patch.

[nielx]

Fixed in hrev54043

[nielx]

Assign tickets with status=closed and resolution=fixed within the R1/beta2 development window to the R1/beta2 Milestone

[diver]

The strings are now translated but the translations are not applied. Could be related to #15904.

[nielx]

Replying to diver:

The strings are now translated but the translations are not applied. Could be related to #15904.

There is a possible relation, but it is not the same problem, since these strings are part of libpackage.so.

The general init of the catalogs for a library are in ​BLocaleRoster::_InitializeCatalog(), which uses a similar method of finding the catalog as libbe does (as described in the other ticket). First step would be to verify that method.

[nielx]

Replying to diver:

The strings are now translated but the translations are not applied. Could be related to #15904.

How did you reproduce this issue?

[diver]

Switch to russian locale (or any other which has these strings translated) and Run SoftwareUpdater.

[nielx]

I tried it with a homebrew build of hrev54105 and the German locale, and I did get translated messages. They also showed up in a pkgman update call (though mixed with English, as expected).

[diver]

After updating from hrev54088 to hrev54105 it works. Except from "Nothing to do" which seems to come from libsolv library.

[nielx]

Replying to diver:

After updating from hrev54088 to hrev54105 it works. Except from "Nothing to do" which seems to come from libsolv library.

I don't find that string in the libsolv library though.

[diver]

Indeed, found it here: src/bin/pkgman/pkgman.cpp:91

[nielx]

Replying to diver:

Indeed, found it here: src/bin/pkgman/pkgman.cpp:91

Right, and we have the policy not to localize command line applications further.

(though this change shows how difficult it is to fully adhere to that policy when we start localizing non-gui libraries).