BSlider label value set issues at min.

[kallisti5]

I noticed this through the DriveSetup app.

• Create a new partition.
• Slide the size to the right (max)
• Take note of the size in the text box and label. (correct)
• Slide the size down to 0.
• The TextControl is the correct size (0) while the label at the top is a random size.
• Sliding over and over to the minimum results in a wide range of numbers as the "minimum" size.

During the slide, Size() in Support.cpp SizeSlider is equal to the random number. SetSize however is equal to the correct "0" value at min.

What's odd is the max value seems to work consistently.

You can also reproduce this by:

• Drag slider to minimum position and release
• Note the Partition Size of != 0 bytes
• Click on the slider half way through the bar.. the Partition Size jumps to 0 bytes while the size text box jumps to the correct size.

[kallisti5]

Ok.. It looks like BSlider::UpdateTextChanged might be at fault.

The logic is all really sketchy, but i think text updates aren't occurring at the proper times. This would explain the Partition Size being "one update behind" in the second example to reproduce.

BSlider::UpdateTextChanged has some really sketchy logic which determines of UpdateText changes based on width of the string :-|

[kallisti5]

I (git) blame stippi :-)

​https://git.haiku-os.org/haiku/commit/src/kits/interface/Slider.cpp?id=1ae794159