Opened 2 months ago

Closed 7 weeks ago

#14622 closed enhancement (fixed)

Thai Keymap

Reported by: chaiwat Owned by: nobody
Priority: normal Milestone: Unscheduled
Component: - General Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

I just create Thai keymap based on US keymap dump file.

The Python script to convert US to Thai keymap is in this repo: https://github.com/cwt/haiku-thai-keymap

The keymap should be named "Thai (TIS-820.2538)" as we have multiple keymaps for Thai, but I didn't use them personally. I may provide more keymaps in the future.

Attachments (1)

th.keymap (16.1 KB) - added by chaiwat 2 months ago.

Download all attachments as: .zip

Change History (7)

Changed 2 months ago by chaiwat

Attachment: th.keymap added

comment:1 Changed 2 months ago by luroh

Cool, I have tried the keymap and it seems to work fine with the Noto regional Thai fonts from what I can tell. Even with a "Thai (TIS-820.2538).keymap" filename.

It would be great if you could submit your keymap in the form of a patch to Gerrit for review and inclusion. Thanks!

comment:2 Changed 2 months ago by waddlesplash

It would be great if you could submit your keymap in the form of a patch to ​Gerrit for review and inclusion. Thanks!

That's not necessary, I'll review and merge it from here.

comment:3 Changed 7 weeks ago by luroh

chaiwat, please submit a patch in Gerrit if you can, it's the official and recommended way to get things reviewed and hopefully merged, as opposed to stuck in limbo here and/or lost.

comment:4 in reply to:  3 Changed 7 weeks ago by chaiwat

Replying to luroh:

chaiwat, please submit a patch in Gerrit if you can, it's the official and recommended way to get things reviewed and hopefully merged, as opposed to stuck in limbo here and/or lost.

I just create a change 641 in Gerrit. The keymap file is in the right path? It's my first time explore Haiku source tree, and also first time using Gerrit.

comment:5 Changed 7 weeks ago by luroh

Looks correct to me. I also pulled your change and it seems to work fine. Now let's wait for a developer to take it from here. Thanks!

comment:6 Changed 7 weeks ago by waddlesplash

Resolution: fixed
Status: newclosed

Merged in hrev52438. Thanks!

Note: See TracTickets for help on using tickets.