Opened 23 months ago

Closed 8 months ago

#14805 closed bug (fixed)

Remove struct size hacks in net80211

Reported by: waddlesplash Owned by: waddlesplash
Priority: blocker Milestone: R1/beta2
Component: Network & Internet/Wireless Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Platform: All

Description

As in title: FreeBSD 12 introduced some new fields in net80211 ioctls that I've held off on adding for the time being so that we preserve ABI compatibility (mostly for wpa_supplicant.) Before beta2, we should remove these hacks, add the new fields, and then rebuild wpa_supplicant.

Change History (6)

comment:1 by kallisti5, 12 months ago

Is this one really a blocker for R1 Beta2?

comment:2 by pulkomandy, 12 months ago

Not really, but it's not a lot of work and there's an ABI change, so just before a release would be better.

comment:3 by pulkomandy, 10 months ago

For reference, the following parts should be reviewed:

/Git/haiku/haiku/src/libs/compat/freebsd_wlan/net80211> git grep __HAIKU__
ieee80211.c:#ifndef __HAIKU__
ieee80211_ioctl.c:#ifdef __HAIKU__
ieee80211_ioctl.c:#ifndef __HAIKU__
ieee80211_ioctl.c:#ifndef __HAIKU__
ieee80211_ioctl.c:#ifdef __HAIKU__
ieee80211_ioctl.c:#ifdef __HAIKU__
ieee80211_ioctl.c:#ifdef __HAIKU__
ieee80211_ioctl.c:#ifndef __HAIKU__
ieee80211_ioctl.h:#ifdef __HAIKU__
ieee80211_ioctl.h:#ifndef __HAIKU__
ieee80211_ioctl.h:#if defined(__FreeBSD__) || defined(__HAIKU__)
ieee80211_ioctl.h:#ifdef __HAIKU__
ieee80211_ioctl.h:#endif /* __HAIKU__ */
ieee80211_ioctl.h:#ifdef __HAIKU__
ieee80211_output.c:#ifdef __HAIKU__
ieee80211_output.c:#ifndef __HAIKU__
ieee80211_ratectl.c:#ifndef __HAIKU__
ieee80211_scan.c:#ifdef __HAIKU__
ieee80211_var.h:#elif defined(__HAIKU__)

comment:5 by nielx, 8 months ago

Ready to go, can be applied just before the branch date.

comment:6 by waddlesplash, 8 months ago

Resolution: fixed
Status: assignedclosed

Merged in hrev54039.

Note: See TracTickets for help on using tickets.