'makeinfo' detection broken in buildtools when using texinfo/makeinfo 4.10 or greater

[kad77]

I've discovered that the 'configure' scripts for legacy gcc and gcc4 will fail if you are using a texinfo package version 4.10 or above. The buildtools will not compile without 'makeinfo'. This updated package will likely hit more that Fedora 7 and Arch in the semi-near future.

The script checks for 'makeinfo' version 4.4 or greater, but due to the exact regex used, 'configure' fails to recognize 4.10 and 4.11 are 'or greater'... and 'makeinfo' is not found, build fails.

Look for this section in the two configure scripts:

if ${MAKEINFO} --version \
| egrep 'texinfo[^0-9]*([1-3][0-9]|4\.[4-9]|[5-9])' >/dev/null 2>&1; then

I have made a slight modification, which fixes the build problem:

egrep 'texinfo[^0-9]*([1-3][0-9]|4\.([4-9]|[1-9][0-9])|[5-9])' >/dev/null 2>&1; then

While this small change works for me, I did not test the fix on an older version of texinfo - though it should work.

[kad77]

While it is the buildtools sections I was referring to, it is the binutils configure script that the fix should be applied to. Patch the main binutils/configure script in both legacy gcc and gcc4 and things should work properly again with more recent texinfo builds.

[bonefish]

Can you attach this change as a patch please. Thanks.

[tombhadac]

Ive attached an patch for it.

[tombhadac]

Patch made with svn diff

[bonefish]

Thanks, applied in hrev22729. I changed the "[0-9][0-9]" to "[1-9][0-9]", though.

[mmu_man]

B_DONT_DO_THAT ! Do *not* change a configure script directly. One must change configure.in and rerun autoconf.

[bonefish]

Thanks for the heads up. It's EDNTDOTHT in this case, though. ;-)