Opened 4 years ago

Closed 23 months ago

Last modified 23 months ago

#16101 closed enhancement (fixed)

Allow using non-system fonts from files with BFont

Reported by: calvinb Owned by: nobody
Priority: normal Milestone: R1/beta5
Component: Kits/Interface Kit Version: R1/Development
Keywords: bfont Cc:
Blocked By: Blocking: #13361
Platform: All

Description (last modified by calvinb)

BFont can only work with fonts installed into the system (packaged/non-packaged). It would be nice to be able to load external fonts from the filesystem.

Use case: private fonts for applications/games not relevant to the rest of the system, applications like font previewers/installers, web browsers with @font-face.

Change History (8)

comment:1 by waddlesplash, 4 years ago

Blocking: 13361 added

comment:2 by calvinb, 4 years ago

Description: modified (diff)

comment:3 by dsizzle, 3 years ago

I posted a review patch to Gerrit: https://review.haiku-os.org/c/haiku/+/4790

Last edited 3 years ago by dsizzle (previous) (diff)

comment:4 by pulkomandy, 23 months ago

Milestone: UnscheduledR1/beta5
Resolution: fixed
Status: newclosed

Patch merged in hrev56649. It seems it was not included in beta4, should we do that or is it too risky?

comment:5 by waddlesplash, 23 months ago

Too risky for now. Let's hold off and merge it later, after it's been well-tested.

comment:6 by madmax, 23 months ago

How about just the interface in BFont (and maybe ServerProtocol) with the implementation returning an error?

comment:7 by dsizzle, 23 months ago

I'm not sure what the benefit of adding just the interface would be.

The risky part, in my opinion, isn't the new font loading, but rather the fact that the global font manager was refactored. If the new font loading is broken it's not a big deal, but if the core font handling turns out to be broken that would be a real shame for beta4.

comment:8 by pulkomandy, 23 months ago

Adding just the interface will allow building the new haikuwebkit releases with beta4 buildbots, even if they can't display custom fonts on beta4. So I can continue making regular haikuwebkit releases

Note: See TracTickets for help on using tickets.