Crashing on GMail (JSC::JSLockHolder::JSLockHolder(JSC::VM&)

[humdinger]

This is with HaikuWebkit 1.6.9, Webkit 610.1.9 (self-compiled)

Sooner rather than later Web+ crashes on GMail's standard webinterface. Full debug report attached.

thread 7517: Web+newest (main)
state: Exception (Segment violation)

Frame		IP			Function Name
-----------------------------------------------
0x71625338	0x59efd6a	JSC::JSLockHolder::JSLockHolder(JSC::VM&) + 0x1a 
	Disassembly:
		JSC::JSLockHolder::JSLockHolder(JSC::VM&):
		0x059efd50:               55  push %ebp
		0x059efd51:             89e5  mov %esp, %ebp
		0x059efd53:               53  push %ebx
		0x059efd54:       e83e2ab4ff  call 0x5532797
		0x059efd59:     81c39bf53100  add $0x31f59b, %ebx
		0x059efd5f:           83ec14  sub $0x14, %esp
		0x059efd62:           8b5508  mov 0x8(%ebp), %edx
		0x059efd65:           8b450c  mov 0xc(%ebp), %eax
		0x059efd68:             8902  mov %eax, (%edx)
		0x059efd6a:           f0ff00  lock inc (%eax) <--

	Frame memory:
		[0x71625320]  .........Sbq`~e(   fb ff ff ff 02 00 00 00 84 53 62 71 60 7e 65 28
		[0x71625330]  Y...la..           59 fd 9e 05 6c 61 cd 04
0x71625388	0x3735a20	WebCore::WindowProxy::createJSWindowProxyWithInitializedScript(WebCore::DOMWrapperWorld&) + 0x30 
0x716253e8	0x36f126f	WebCore::ScriptController::jsWindowProxy(WebCore::DOMWrapperWorld&) + 0xef 
0x71625408	0x36cc252	WebCore::toJSDOMWindow(WebCore::Frame&, WebCore::DOMWrapperWorld&) + 0x22 
0x71625468	0x36fc5b7	WebCore::ScheduledAction::execute(WebCore::Document&) + 0x37 
0x71625488	0x36fc713	WebCore::ScheduledAction::execute(WebCore::ScriptExecutionContext&) + 0x33 
0x71625528	0x3c6b236	WebCore::DOMTimer::fired() + 0x2a6 
0x71625578	0x3d9db6c	WebCore::ThreadTimers::sharedTimerFiredInternal() + 0x7c 
0x71625598	0x3d9dc8d	_ZN3WTF6Detail15CallableWrapperIZN7WebCore12ThreadTimers14setSharedTimerEPNS2_11SharedTimerEEUlvE_vJEE4callEv + 0x1d 
0x716257a0	0x2387262	BApplication::DispatchMessage(BMessage*, BHandler*) + 0x1f2 
0x716257f0	0x238f3cc	BLooper::task_looper() + 0x26c 
0x71625810	0x2383de8	BApplication::Run() + 0x28 
0x71625860	0x15bfa62	main + 0x42 
0x71625878	0x15bfc69	_start + 0x39 
0x716258b8	0x25e37ee	runtime_loader + 0x132 
00000000	0x604d1258	commpage_thread_exit + 0 

[waddlesplash]

Maybe this change from October is relevant, i.e. we are not handling TLS properly in WebKit? ​https://github.com/WebKit/webkit/commit/f5c681e257319ab68d5b880e2eb620be048ecd4b

[waddlesplash]

Ah never mind, it was reverted later: ​https://github.com/WebKit/webkit/commit/899b2ddcaf3b20963afa98f02bf6fff027ab5e7e

So that is not the problem.

[humdinger]

Self-compiled WebKit (​​https://github.com/WebKit/webkit/commit/a76b8f20242835bb72159a1fc70c59f3faa00c51) seems to have fixed those crashes on GMail. At least I've been clicking around for 10 minutes with no issues (other than some buttons need two clicks, there's a ticket for that, I think).

[nephele]

Thanks for testing