Some Japanese text missing in Webpositive

[mt]

Since hrev54241, some Japanese text is missing in Webpositive.

To reproduce:

1. Set Japanese fonts in Apparence.
2. Set Japanese fonts in Webpositive settings.
3. Open Japanese version of "Welcome to haiku" (or Quick tour, userguide) in Webpositive.

[mt]

Webpositive opening Japanese version of "Welcome to Haiku!" in hrev54240

[mt]

Webpositive opening Japanese version of "Welcome to Haiku!" in hrev54241

[waddlesplash]

It looks like this makes Haiku unusable in Japanese, yes? Upgrading to Blocker status. Thanks for reporting this mt, we were going to cut off beta2 later today, but now we should probably wait until this is fixed :)

[mt]

Replying to waddlesplash:

It looks like this makes Haiku unusable in Japanese, yes? Upgrading to Blocker status. Thanks for reporting this mt, we were going to cut off beta2 later today, but now we should probably wait until this is fixed :)

Hi, Otter Browser can display these pages correctly. So I think we can use Haiku with Japanese.

[waddlesplash]

Otter Browser uses Qt and FreeType directly to render text, not app_server as WebPositive uses. See if StyledEdit will render those characters; likely it won't.

[mt]

Replying to waddlesplash:

Otter Browser uses Qt and FreeType directly to render text, not app_server as WebPositive uses. See if StyledEdit will render those characters; likely it won't.

It seems StyledEdit can display welcome_jp.html correctly.

[mt]

StyledEdit opening welcome_jp.html in hrev54241.

[X512]

Picture dump of Haiku へようこそ！ part:

PUSH_STATE
	SET_DRAWING_MODE
		mode: B_OP_OVER
	ENTER_FONT_STATE {
		SET_FONT_FAMILY
			family: "Noto Sans"
		SET_FONT_STYLE
			style: "Regular"
		SET_FONT_SIZE
			size: 12.6
		SET_FONT_SHEAR
			shear: 90
		SET_FONT_ROTATE
			rotation: 0
		SET_FONT_SPACING
		SET_FONT_ENCODING
		SET_FONT_FACE
		SET_FONT_FLAGS
	}
	DRAW_STRING_LOCATIONS
		pointList: {
			(703, 191)
			(712, 191)
			(719, 191)
			(722, 191)
			(728, 191)
			(735, 191)
			(738, 191)
			(750, 191)
		}
		string: "Haiku へよ"
	POP_STATE
PUSH_STATE
	SET_DRAWING_MODE
		mode: B_OP_OVER
	SET_FORE_COLOR
		color: 0xff013cdc
	ENTER_FONT_STATE {
		SET_FONT_FAMILY
			family: "Noto Sans CJK JP"
		SET_FONT_STYLE
			style: "Regular"
		SET_FONT_SIZE
			size: 12.6
		SET_FONT_SHEAR
			shear: 90
		SET_FONT_ROTATE
			rotation: 0
		SET_FONT_SPACING
		SET_FONT_ENCODING
		SET_FONT_FACE
		SET_FONT_FLAGS
	}
	DRAW_STRING_LOCATIONS
		pointList: {
			(762, 191)
		}
		string: "う"
	POP_STATE
PUSH_STATE
	SET_DRAWING_MODE
		mode: B_OP_OVER
	SET_FORE_COLOR
		color: 0xff013cdc
	ENTER_FONT_STATE {
		SET_FONT_FAMILY
			family: "Noto Sans"
		SET_FONT_STYLE
			style: "Regular"
		SET_FONT_SIZE
			size: 12.6
		SET_FONT_SHEAR
			shear: 90
		SET_FONT_ROTATE
			rotation: 0
		SET_FONT_SPACING
		SET_FONT_ENCODING
		SET_FONT_FACE
		SET_FONT_FLAGS
	}
	DRAW_STRING_LOCATIONS
		pointList: {
			(774, 191)
			(786, 191)
			(798, 191)
		}
		string: "こそ!"
	POP_STATE

Splitting looks strange.

[waddlesplash]

Why did the character in the middle get "CJK JP" selected, but the others did not? That looks extremely strange.

PictureDump looks like a very useful tool, though!

[miasmaeternal]

I think ​this commit broke it - it might be a problem with the fallback fonts array and the loop function.

[waddlesplash]

How would that be? The loop looks OK to me anyway.

[waddlesplash]

The most likely culprit is one of the two parent commits which change how fallback glyphs are looked up. However on first glance I don't see any immediate problem.

[waddlesplash]

Fixed in hrev54299.

[mt]

Replying to waddlesplash:

Fixed in hrev54299.

Thanks for patch, but in hrev54299, text is ok, but the style seems still strange.

[mt]

Webpositive opening Japanese version of "Welcome to Haiku!" in hrev54299.

[waddlesplash]

Yes, I saw this too. Please open a new ticket about it, I'm not sure if it's yet another app_server bug, or actually a bug in HaikuWebKit.

[pulkomandy]

It could just be missing glyphs in the Noto font or something like that too. We should probably update the fonts before going further with this?

[waddlesplash]

I don't think so. The first screenshot clearly shows the characters in bold-face. Now they are still shown, but no longer in bold-face. So somehow they used to be found inside the "CJK JP Bold" font, but, now they aren't.

[nephele]

It could just be missing glyphs in the Noto font or something like that too. We should probably update the fonts before going further with this?

No they aren't missing, WebPositive requests some segments with Noto Sans and some with Noto Sans CJK JP for that section, for some reason the text splitting changes when you zoom in and out in webpositive so sometimes the I glyph and the ! glyph are bold and sometimes they arent, anyway that would the "most" webpositive might be doing wrong (requesting with noto sans while config sais noto sans cjk jp)

Noto Sans bold Fallback is still broken, that hrev did not fix that, instead it now falls back to regular style, which isn't perfect, but better than falling back to nothing as it did before.

[mt]

I add new ticket #16212 (Some Japanese text style missing in Webpositive).